[editor] Use the fit-curve package (issue 15004)
#15142
Conversation
Rather than including all of this external code in the PDF.js repository, we should be using the npm package instead. Unfortunately this is slightly more complicated than you'd hope, since the `fit-curve` package (which is older) isn't directly compatible with modern JavaScript modules. In particular, the following cases needed to be considered: - For the development viewer (i.e. `gulp server`) and the unit-tests, we thus need to build a fitCurve-bundle that can be directly `import`ed. - For the actual PDF.js build-targets, we can slightly reduce the sizes by depending on the "raw" `fit-curve` source-code. - For the Node.js unit-tests, the `fit-curve` package can be used as-is.
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/94bafc0854d0b97/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/94bafc0854d0b97/output.txt Total script time: 2.71 mins Published |
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/a5097f73fd2737c/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/6245336fd11487c/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/a5097f73fd2737c/output.txt Total script time: 25.77 mins
Image differences available at: http://54.241.84.105:8877/a5097f73fd2737c/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/6245336fd11487c/output.txt Total script time: 29.16 mins
Image differences available at: http://54.193.163.58:8877/6245336fd11487c/reftest-analyzer.html#web=eq.log |
Would you mind to file a bug upstream in order to modernize the package ? |
Yes, it's already on my TODO list :-) |
Rather than including all of this external code in the PDF.js repository, we should be using the npm package instead.
Unfortunately this is slightly more complicated than you'd hope, since the
fit-curvepackage (which is older) isn't directly compatible with modern JavaScript modules.In particular, the following cases needed to be considered:
gulp server) and the unit-tests, we thus need to build a fitCurve-bundle that can be directlyimported.fit-curvesource-code.fit-curvepackage can be used as-is.