-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Adjust the heuristics for handling of incomplete path operators (issue 14917) #14921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…e 14917) This limits the heuristics for handling of incomplete path operators, see PR 9838, to only apply to *sequences* of such operators. In practice a couple of invalid path operators are (hopefully) unlikely to completely break rendering, whereas a sequence of them will easily lead to fairly chaotic rendering artifacts.
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/fad2160a81e0f5a/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/fad2160a81e0f5a/output.txt Total script time: 2.56 mins Published |
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/4199b0566e3151a/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 1 Live output at: http://54.193.163.58:8877/43fc54608f3ddf4/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/4199b0566e3151a/output.txt Total script time: 25.60 mins
Image differences available at: http://54.241.84.105:8877/4199b0566e3151a/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/43fc54608f3ddf4/output.txt Total script time: 31.60 mins
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you.
/botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/6d2bd79b76a7641/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 1 Live output at: http://54.193.163.58:8877/680247c737f4717/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/6d2bd79b76a7641/output.txt Total script time: 22.79 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/680247c737f4717/output.txt Total script time: 24.54 mins
|
This limits the heuristics for handling of incomplete path operators, see PR #9838, to only apply to sequences of such operators. In practice a couple of invalid path operators are (hopefully) unlikely to completely break rendering, whereas a sequence of them will easily lead to fairly chaotic rendering artifacts.