-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Decode non-ASCII values found in the xfa:datasets (PR 14735 follow-up) #14738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decode non-ASCII values found in the xfa:datasets (PR 14735 follow-up) #14738
Conversation
*Please note:* This is possibly bad/wrong in general, but I figured that submitting it for review wouldn't hurt. It seems that even Adobe Reader doesn't handle the non-ASCII characters that appear in some of the fields correctly, however it should be pretty easy to improve things on the PDF.js side.
Eh eh, you've been faster than me: it was on my todo list. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thank you.
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/d617a21f0bfe0da/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/55e78b225ba1323/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/55e78b225ba1323/output.txt Total script time: 23.69 mins
Image differences available at: http://54.241.84.105:8877/55e78b225ba1323/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/d617a21f0bfe0da/output.txt Total script time: 26.29 mins
Image differences available at: http://54.193.163.58:8877/d617a21f0bfe0da/reftest-analyzer.html#web=eq.log |
/botio makeref |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 1 Live output at: http://54.193.163.58:8877/a27018a5e92dda9/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/6f86234af4de02b/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/6f86234af4de02b/output.txt Total script time: 20.73 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/a27018a5e92dda9/output.txt Total script time: 21.38 mins
|
Please note: This is possibly bad/wrong in general, but I figured that submitting it for review wouldn't hurt.
It seems that even Adobe Reader doesn't handle the non-ASCII characters that appear in some of the fields correctly, however it should be pretty easy to improve things on the PDF.js side.