Skip to content

[Annotations] Some annotations can have their values stored in the xfa:datasets #14735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2022

Conversation

calixteman
Copy link
Contributor

@calixteman
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/c598aab85431eca/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/b64cdb23924075e/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/c598aab85431eca/output.txt

Total script time: 23.67 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 6
  different first/second rendering: 2

Image differences available at: http://54.241.84.105:8877/c598aab85431eca/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/b64cdb23924075e/output.txt

Total script time: 26.31 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: Passed

…a:datasets

- it aims to fix mozilla#14685;
- add a basic object to get values from the parsed datasets;
- these annotations don't have an appearance so we must create one when printing or saving.
@calixteman
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Apr 1, 2022

From: Bot.io (Linux m4)


Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/c03fcd002d76fbf/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Apr 1, 2022

From: Bot.io (Windows)


Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/c18ddb70302f8eb/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Apr 1, 2022

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/c03fcd002d76fbf/output.txt

Total script time: 23.68 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 5
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/c03fcd002d76fbf/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

pdfjsbot commented Apr 1, 2022

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/c18ddb70302f8eb/output.txt

Total script time: 26.46 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 1

Image differences available at: http://54.193.163.58:8877/c18ddb70302f8eb/reftest-analyzer.html#web=eq.log

Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, this looks reasonable; thank you!

@Snuffleupagus Snuffleupagus merged commit 36a289d into mozilla:master Apr 1, 2022
@Snuffleupagus
Copy link
Collaborator

/botio makeref

@pdfjsbot
Copy link

pdfjsbot commented Apr 1, 2022

From: Bot.io (Linux m4)


Received

Command cmd_makeref from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/de461f25b7d2ae7/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Apr 1, 2022

From: Bot.io (Windows)


Received

Command cmd_makeref from @Snuffleupagus received. Current queue size: 1

Live output at: http://54.193.163.58:8877/09cc61bb8765833/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Apr 1, 2022

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/de461f25b7d2ae7/output.txt

Total script time: 20.79 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

pdfjsbot commented Apr 1, 2022

From: Bot.io (Windows)


Success

Full output at http://54.193.163.58:8877/09cc61bb8765833/output.txt

Total script time: 21.25 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

calixteman added a commit to calixteman/pdf.js that referenced this pull request Apr 1, 2022
calixteman added a commit to calixteman/pdf.js that referenced this pull request Apr 1, 2022
calixteman added a commit to calixteman/pdf.js that referenced this pull request Apr 3, 2022
conghoang added a commit to conghoang/pdf.js that referenced this pull request Apr 7, 2022
* commit '27e738dff951160420575216c080e22027af0a86': (198 commits)
  Refactor some xfa*** getters in document.js - it's a follow-up of PR mozilla#14735.
  Convert `web/debugger.js` to a *basic* module
  Update translations to the most recent versions
  Update dependencies to the most recent versions
  Update GitHub Actions workflow steps to the most recent versions
  Replace most loops in `web/debugger.js` with `for...of` loops
  Decode non-ASCII values found in the xfa:datasets (PR 14735 follow-up)
  [Annotations] Some annotations can have their values stored in the xfa:datasets - it aims to fix mozilla#14685; - add a basic object to get values from the parsed datasets; - these annotations don't have an appearance so we must create one when printing or saving.
  [GENERIC viewer] Try to improve a11y, for search results, in the findbar (issue 14525)
  Don't manually convert `setAttribute` values to strings (PR 14554 follow-up)
  Use `String.prototype.repeat()` in a couple of spots
  [Annotations] Add support for printing/saving choice list with multiple selections - it aims to fix issue mozilla#12189.
  Add a `<dialog>` polyfill for the `generic-legacy` build
  Try to improve a11y for the `PasswordPrompt` and `PDFDocumentProperties` dialogs
  Re-factor the `OverlayManager` class to use a `WeakMap` internally
  Convert the existing overlays to use `<dialog>` elements (issue 14698)
  [text selection] Add the whitespaces present in the pdf in the text chunk - it aims to fix issue mozilla#14627; - the basic idea of the recent text refactoring was to only consider the rendered visible whitespaces.   But sometimes, the heuristics aren't correct and although some whitespaces are in the text stream   they weren't in the text chunks because they were too small. Hence we added some exceptions, for example,   we always add a whitespace when it is between two non-whitespace chars but only when in the same Tj.   So basically, this patch removes the constraint to have the chars in the same Tj   (in using a circular buffer to save the two last chars) but don't add a space when the visible space is really   too small (hence `NOT_A_SPACE_FACTOR`).
  Change the type of the `container` property, in the `TextLayerRenderParameters` typedef (issue 14716)
  Avoid the `textLayer` becoming visible in high contrast mode (issue 13230)
  Remove the remaining `dir`-dependent CSS rules
  ...

# Conflicts:
#	package-lock.json
#	src/pdf.js
bh213 pushed a commit to bh213/pdf.js that referenced this pull request Jun 3, 2022
rousek pushed a commit to signosoft/pdf.js that referenced this pull request Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PDFJS is not able to show prefilled Acroform PDF with data in xfa:dataset
3 participants