-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Cleanup workflows #14625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup workflows #14625
Conversation
Removed setup-node cuz is already included in the docker image
It is preinstalled, too!
Can you please provide links to official resources that confirm that these changes are desirable/correct? Also, please use proper English in commit messages (and code-comments); hence replace "cuz" with the correct word. Finally, please see https://github.com/mozilla/pdf.js/wiki/Squashing-Commits |
@@ -7,15 +7,7 @@ jobs: | |||
|
|||
steps: | |||
- name: Checkout repository | |||
uses: actions/checkout@v2 | |||
|
|||
- name: Use Node.js 16 LTS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I'm not sure that we want to lose the ability to manually specify the exact Node.js that we use for testing!?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I agree, maybe keeping setup-node can be the soulution is important. I can find for you the source of the information, but if you are intersted to force a specific nodejs version I cannot change your mind.
I'm really sorry if I wasn't following the guidelines... If you prefer you can make a commit directly when you have time... Otherwise I will fix/stash everything |
Here the links https://github.com/actions/virtual-environments/blob/main/images/linux/Ubuntu2004-Readme.md |
Initially I was a bit confused about why the I do agree that it would be good to be explicit about the Node.js version we're testing against so it doesn't go unnoticed when the upstream image is updated for example. In general we want all our dependencies to be explicit, and Node.js happens to be the only one that we can't enforce easily through e.g., Therefore, this PR should be fine with the Node.js part put back and the commits squashed into one with a meaningful commit message. |
I will remake soon the PR, let me close for a moment please |
No description provided.