Don't close window from test driver. #14608
Conversation
Sometimes I get a "Unable to find target with id XXX closeTarget..." error when running tests which happens when test.js tries to close all the open pages. I haven't been able to fully verify since this is intermittent, but I think this is coming from us closing the window in driver.js and also trying to close it in test.js.
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @brendandahl received. Current queue size: 2 Live output at: http://54.241.84.105:8877/795b1fea74fba05/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @brendandahl received. Current queue size: 2 Live output at: http://54.193.163.58:8877/5bbce796f5abc29/output.txt |
|
Seems to be happening on the bots too. See this recent makeref that failed. |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/795b1fea74fba05/output.txt Total script time: 23.58 mins
Image differences available at: http://54.241.84.105:8877/795b1fea74fba05/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/5bbce796f5abc29/output.txt Total script time: 25.94 mins
Image differences available at: http://54.193.163.58:8877/5bbce796f5abc29/reftest-analyzer.html#web=eq.log |
|
Given that this is very old code, it seems to me that it perhaps became unnecessary back when Puppeteer was originally introduced? |
Sometimes I get a "Unable to find target with id XXX closeTarget..." error
when running tests which happens when test.js tries to close all the
open pages. I haven't been able to fully verify since this is intermittent,
but I think this is coming from us closing the window in driver.js and also
trying to close it in test.js.