Simplify the wrapReason helper function
#14607
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All call-sites that use `wrapReason` should be passing a (possibly cloned) `Error` to the helper function, hence we shouldn't need to have a fallback code-path for any other data. Note that for the `cancel`/`error` methods on Streams, since PR 11115 we've been asserting that the argument is in fact an `Error` as intended. When calling `wrapReason` from *rejected* Promises, we should also be guaranteed that an `Error` is provided thanks to the ESLint rules `no-throw-literal` and `prefer-promise-reject-errors`.
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/ec32a79d43c1c9f/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/63d6a3169815156/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/ec32a79d43c1c9f/output.txt Total script time: 23.49 mins
Image differences available at: http://54.241.84.105:8877/ec32a79d43c1c9f/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/63d6a3169815156/output.txt Total script time: 26.07 mins
|
timvandermeij
approved these changes
Feb 26, 2022
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All call-sites that use
wrapReasonshould be passing a (possibly cloned)Errorto the helper function, hence we shouldn't need to have a fallback code-path for any other data.Note that for the
cancel/errormethods on Streams, since PR #11115 we've been asserting that the argument is in fact anErroras intended.When calling
wrapReasonfrom rejected Promises, we should also be guaranteed that anErroris provided thanks to the ESLint rulesno-throw-literalandprefer-promise-reject-errors.