Skip to content

Simplify the decodeFontData/encodeFontData font-test helper functions #14605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2022

Conversation

Snuffleupagus
Copy link
Collaborator

We can (and in my opinion should) use the standard atob/btoa functions, rather than manually re-implementing this functionality for the font-tests.

…ions

We can (and in my opinion should) use the standard `atob`/`btoa` functions, rather than manually re-implementing this functionality for the font-tests.
@Snuffleupagus
Copy link
Collaborator Author

/botio fonttest

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_fonttest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/787e08bb02fc06d/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_fonttest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/c09756d9a266385/output.txt

Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With green tests, r=me.
Thank you.

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/787e08bb02fc06d/output.txt

Total script time: 1.56 mins

  • Font Tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://54.193.163.58:8877/c09756d9a266385/output.txt

Total script time: 3.92 mins

  • Font Tests: Passed

@Snuffleupagus Snuffleupagus merged commit b753271 into mozilla:master Feb 25, 2022
@Snuffleupagus Snuffleupagus deleted the font-test-atob-btoa branch February 25, 2022 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants