Re-factor the PDFDocument.documentInfo method, and remove the isString helper function
#14602
Conversation
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/f3e742027fb90ba/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/0e473ba8e2e16b6/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/f3e742027fb90ba/output.txt Total script time: 23.57 mins
Image differences available at: http://54.241.84.105:8877/f3e742027fb90ba/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/0e473ba8e2e16b6/output.txt Total script time: 24.96 mins
Image differences available at: http://54.193.163.58:8877/0e473ba8e2e16b6/reftest-analyzer.html#web=eq.log |
This removes the `DocumentInfoValidators` structure, and thus (slightly) simplifies the code overall. With these changes we only have to iterate through, and validate, the actually available Dictionary entries.
The call-sites are replaced by direct `typeof`-checks instead, which removes unnecessary function calls. Note that in the `src/`-folder we already had more `typeof`-cases than `isString`-calls.
Snuffleupagus
force-pushed
the
rm-isString
branch
from
9584e0e to
99cd24c
Compare
|
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/d1c170e01f98a3b/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/c106c6a849b3ebb/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/d1c170e01f98a3b/output.txt Total script time: 3.40 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/c106c6a849b3ebb/output.txt Total script time: 6.21 mins
|
Re-factor the
PDFDocument.documentInfomethodThis removes the
DocumentInfoValidatorsstructure, and thus (slightly) simplifies the code overall. With these changes we only have to iterate through, and validate, the actually available Dictionary entries.Remove the
isStringhelper functionThe call-sites are replaced by direct
typeof-checks instead, which removes unnecessary function calls. Note that in thesrc/-folder we already had moretypeof-cases thanisString-calls.