-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Remove the isRef
helper function
#14577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/0d2dcc1f8e392c6/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/9cc9e4c8046e081/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/0d2dcc1f8e392c6/output.txt Total script time: 23.15 mins
Image differences available at: http://54.241.84.105:8877/0d2dcc1f8e392c6/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/9cc9e4c8046e081/output.txt Total script time: 25.20 mins
Image differences available at: http://54.193.163.58:8877/9cc9e4c8046e081/reftest-analyzer.html#web=eq.log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me with a rebase since the first commit was already part of another PR; thanks!
This helper function is not really needed, since it's just a wrapper around a simple `instanceof` check, and it only adds unnecessary indirection in the code.
8abdfd7
to
2cb2f63
Compare
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/24adfe6a1a8c057/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/529794ecf5382ad/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/24adfe6a1a8c057/output.txt Total script time: 3.10 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/529794ecf5382ad/output.txt Total script time: 6.80 mins
|
This helper function is not really needed, since it's just a wrapper around a simple
instanceof
check, and it only adds unnecessary indirection in the code.