Fix canvas state getting out of sync from smasks. (bug 1755507) #14569
Conversation
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @brendandahl received. Current queue size: 0 Live output at: http://54.241.84.105:8877/53a17f3909cdeee/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @brendandahl received. Current queue size: 0 Live output at: http://54.193.163.58:8877/9813b6410885eb2/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/53a17f3909cdeee/output.txt Total script time: 23.12 mins
Image differences available at: http://54.241.84.105:8877/53a17f3909cdeee/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/9813b6410885eb2/output.txt Total script time: 25.67 mins
Image differences available at: http://54.193.163.58:8877/9813b6410885eb2/reftest-analyzer.html#web=eq.log |
|
Interesting, I don't have that one in my smask tests cases. I think this is also similar to #14297 where the state is getting out of sync between canvases. It seems to be the reverse though, when we re-begin smask mode from restore. |
brendandahl
force-pushed
the
smask-state
branch
from
0b65ce8 to
25bd3be
Compare
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @brendandahl received. Current queue size: 0 Live output at: http://54.241.84.105:8877/004aeef2c7d8977/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @brendandahl received. Current queue size: 0 Live output at: http://54.193.163.58:8877/326c316577b8c32/output.txt |
brendandahl
force-pushed
the
smask-state
branch
from
25bd3be to
bbda5dc
Compare
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/004aeef2c7d8977/output.txt Total script time: 26.64 mins
Image differences available at: http://54.241.84.105:8877/004aeef2c7d8977/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/326c316577b8c32/output.txt Total script time: 33.37 mins
Image differences available at: http://54.193.163.58:8877/326c316577b8c32/reftest-analyzer.html#web=eq.log |
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @brendandahl received. Current queue size: 0 Live output at: http://54.241.84.105:8877/a43a9d1ac8a5c5c/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @brendandahl received. Current queue size: 0 Live output at: http://54.193.163.58:8877/a9a6cd2ed554d3c/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/a43a9d1ac8a5c5c/output.txt Total script time: 23.52 mins
Image differences available at: http://54.241.84.105:8877/a43a9d1ac8a5c5c/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/a9a6cd2ed554d3c/output.txt Total script time: 25.70 mins
Image differences available at: http://54.193.163.58:8877/a9a6cd2ed554d3c/reftest-analyzer.html#web=eq.log |
Soft masks can be enabled/disabled at anytime and at different points in the save/restore stack. This can lead to the amount of save/restores becoming unbalanced across the two canvases. Instead of save/restoring on the temporary canvas change it so we only track state on the main (suspended canvas). I was also getting an out balance stack from patterns, so I've also fixed that and added a warning that will at least show up on chrome. It would be nice to add this so Firefox at some point too. Fixes mozilla#11328, mozilla#14297 and bug 1755507
brendandahl
force-pushed
the
smask-state
branch
from
bbda5dc to
7def6d1
Compare
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/6ecc69c74d43f91/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/160a0248740c957/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/6ecc69c74d43f91/output.txt Total script time: 23.20 mins
Image differences available at: http://54.241.84.105:8877/6ecc69c74d43f91/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/160a0248740c957/output.txt Total script time: 25.08 mins
Image differences available at: http://54.193.163.58:8877/160a0248740c957/reftest-analyzer.html#web=eq.log |
|
/botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/f0c65ef0427851b/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/4da49171f00d81c/output.txt |
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/4da49171f00d81c/output.txt Total script time: 20.24 mins
|
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/f0c65ef0427851b/output.txt Total script time: 20.41 mins
|
Soft masks can be enabled/disabled at anytime and at different
points in the save/restore stack. This can lead to
the amount of save/restores becoming unbalanced across the
two canvases. Instead of save/restoring on the temporary canvas
change it so we only track state on the main (suspended canvas).
I was also getting an out balance stack from patterns, so I've also
fixed that and added a warning that will at least show up on chrome.
It would be nice to add this so Firefox at some point too.
Fixes #11328, #14297 and bug 1755507