Miscellaneous small viewer clean-up #14566
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snuffleupagus
force-pushed
the
misc-viewer-cleanup
branch
from
c404ca3 to
c347473
Compare
Given that the `Navigator` interface has been available since "forever", please see https://developer.mozilla.org/en-US/docs/Web/API/Navigator#browser_compatibility, it's somewhat difficult to see why these checks are actually necessary since the viewer is only intended for usage in browsers. Looking at the history of the code, this functionality was originally placed in the general `src/shared/compatibility.js` file which could thus run in e.g. worker-threads and Node.js environments (where the `Navigator` interface isn't available).
This is consistent with the `open` method, and it actually *ever so slightly* reduces the size of the file.
Snuffleupagus
force-pushed
the
misc-viewer-cleanup
branch
from
c347473 to
996396a
Compare
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/858e9a9371ed94a/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/858e9a9371ed94a/output.txt Total script time: 2.62 mins Published |
timvandermeij
approved these changes
Feb 16, 2022
|
Thank you for improving this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the
typeof navigator-checks in theweb/app_options.jsfileGiven that the
Navigatorinterface has been available since "forever", please see https://developer.mozilla.org/en-US/docs/Web/API/Navigator#browser_compatibility, it's somewhat difficult to see why these checks are actually necessary since the viewer is only intended for usage in browsers.Looking at the history of the code, this functionality was originally placed in the general
src/shared/compatibility.jsfile which could thus run in e.g. worker-threads and Node.js environments (where theNavigatorinterface isn't available).Change
PasswordPrompt.closeto anasyncmethodThis is consistent with the
openmethod, and it actually ever so slightly reduces the size of the file.