[api-minor] Don't add in the text content the chars which are out-of-page (bug 1755201) #14564
Conversation
calixteman
commented
Feb 13, 2022
•
calixteman
commented
- it aims to fix https://bugzilla.mozilla.org/show_bug.cgi?id=1755201;
- if the glyph position is not within the view then skip it.
Snuffleupagus
changed the title
calixteman
force-pushed
the
bug1755201
branch
2 times, most recently
from
a294d38 to
855e87b
Compare
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/74e5c86af6a4d77/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/aa626dbc2a11705/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/aa626dbc2a11705/output.txt Total script time: 4.33 mins
Image differences available at: http://54.241.84.105:8877/aa626dbc2a11705/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/74e5c86af6a4d77/output.txt Total script time: 6.64 mins
Image differences available at: http://54.193.163.58:8877/74e5c86af6a4d77/reftest-analyzer.html#web=eq.log |
…page (bug 1755201) - it aims to fix https://bugzilla.mozilla.org/show_bug.cgi?id=1755201; - if the glyph position is not within the view then skip it.
calixteman
force-pushed
the
bug1755201
branch
from
855e87b to
18e3a98
Compare
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/6e4136adb749cf6/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/1e4d70cb026620a/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/1e4d70cb026620a/output.txt Total script time: 23.96 mins
Image differences available at: http://54.241.84.105:8877/1e4d70cb026620a/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/6e4136adb749cf6/output.txt Total script time: 24.89 mins
Image differences available at: http://54.193.163.58:8877/6e4136adb749cf6/reftest-analyzer.html#web=eq.log |
There was a problem hiding this comment.
This seems reasonable to me, thank you!
This was tagged [api-minor] since it's an observable change of a behaviour that's existed since "forever", and there's always a risk that some users depend on the old behaviour.
While it'd obviously be possible to add an option to toggle this on/off, I'm suggesting that we do not do so speculatively since all options have maintenance/testing overhead.
