[api-minor] Remove the, in legacy builds, bundled ReadableStream polyfill
#14560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snuffleupagus
force-pushed
the
Node-ReadableStream-polyfill
branch
3 times, most recently
from
7406ca6 to
de81b2f
Compare
…polyfill According to the MDN compatibility data, see https://developer.mozilla.org/en-US/docs/Web/API/ReadableStream#browser_compatibility, all browsers that we support have native `ReadableStream` implementations (since quite some time too). Hence only Node.js is now lagging behind w.r.t. `ReadableStream` support, and its experimental implementation doesn't really help us given the life-span of the LTS releases (see https://en.wikipedia.org/wiki/Node.js#Releases). It seems quite unfortunate to bundle a `ReadableStream` polyfill in the `legacy` builds when it's unnecessary in browsers, given its overall size, but fortunately we can avoid that by simply listing `web-streams-polyfill` as a dependency for the `pdfjs-dist` library.
Snuffleupagus
force-pushed
the
Node-ReadableStream-polyfill
branch
from
de81b2f to
b89595f
Compare
|
/botio xfatest |
From: Bot.io (Linux m4)ReceivedCommand cmd_xfatest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/9767cb99e143965/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_xfatest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/ac24ad566f1779c/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/9767cb99e143965/output.txt Total script time: 10.21 mins
Image differences available at: http://54.241.84.105:8877/9767cb99e143965/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/ac24ad566f1779c/output.txt Total script time: 12.48 mins
Image differences available at: http://54.193.163.58:8877/ac24ad566f1779c/reftest-analyzer.html#web=eq.log |
timvandermeij
approved these changes
Feb 13, 2022
|
Good idea! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the MDN compatibility data, see https://developer.mozilla.org/en-US/docs/Web/API/ReadableStream#browser_compatibility, all browsers that we support have native
ReadableStreamimplementations (since quite some time too).Hence only Node.js is now lagging behind w.r.t.
ReadableStreamsupport, and its experimental implementation doesn't really help us given the life-span of the LTS releases (see https://en.wikipedia.org/wiki/Node.js#Releases).It seems quite unfortunate to bundle a
ReadableStreampolyfill in thelegacybuilds when it's unnecessary in browsers, given its overall size, but fortunately we can avoid that by simply listingweb-streams-polyfillas a dependency for thepdfjs-distlibrary.