Take into account all rotations before comparing glyph positions #14500
Conversation
calixteman
commented
Jan 26, 2022
calixteman
commented
- it aims to fix getTextContent Returns wrong text (with spaces removed) #14497;
- previously, only rotations with an angle 0, 90, 180 or 270 were taken into account;
- so generalize to any angle but keep the fast path for 0, 90, ... because they're likely more common than anything else.
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/c10a313e266b71e/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/4ac81dfca19b6a0/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/c10a313e266b71e/output.txt Total script time: 23.30 mins
Image differences available at: http://54.241.84.105:8877/c10a313e266b71e/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/4ac81dfca19b6a0/output.txt Total script time: 41.19 mins
Image differences available at: http://54.193.163.58:8877/4ac81dfca19b6a0/reftest-analyzer.html#web=eq.log |
- it aims to fix mozilla#14497; - previously, only rotations with an angle 0, 90, 180 or 270 were taken into account; - so generalize to any angle but keep the fast path for 0, 90, ... because they're likely more common than anything else.
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/06fbb3698d9acd6/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/696341842f6c98d/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/696341842f6c98d/output.txt Total script time: 23.38 mins
Image differences available at: http://54.241.84.105:8877/696341842f6c98d/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/06fbb3698d9acd6/output.txt Total script time: 41.37 mins
Image differences available at: http://54.193.163.58:8877/06fbb3698d9acd6/reftest-analyzer.html#web=eq.log |
|
/botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/a7658e6cd43d9aa/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 1 Live output at: http://54.193.163.58:8877/26df0dd6721f0d9/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/a7658e6cd43d9aa/output.txt Total script time: 20.63 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/26df0dd6721f0d9/output.txt Total script time: 37.79 mins
|
commit a69adf0 Merge: 5c3b245 3a7004c Author: Jonas Jenwald <[email protected]> Date: Wed Jan 26 18:04:57 2022 +0100 Merge pull request mozilla#14500 from calixteman/14497 Take into account all rotations before comparing glyph positions commit 3a7004c Author: Calixte Denizet <[email protected]> Date: Wed Jan 26 15:35:46 2022 +0100 Take into account all rotations before comparing glyph positions - it aims to fix mozilla#14497; - previously, only rotations with an angle 0, 90, 180 or 270 were taken into account; - so generalize to any angle but keep the fast path for 0, 90, ... because they're likely more common than anything else.
