web: Read WheelEvent.deltaMode before deltas. #14495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that Firefox doesn't switch to pixel mode for compat with other browsers. This should fix mozilla#14476, in terms of restoring the previous behavior. We probably want to change the pixel-based scrolling code to not scroll so much (the deltaMode stuff normalizes to +/-1 tick for each wheel event, perhaps the pixel-based value should do the same).
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/7c5a8f3c5e4b68f/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/7c5a8f3c5e4b68f/output.txt Total script time: 4.61 mins Published |
Snuffleupagus
approved these changes
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that Firefox doesn't switch to pixel mode for compat with other
browsers.
This should fix #14476, in terms
of restoring the previous behavior.
We probably want to change the pixel-based scrolling code to not scroll
so much (the deltaMode stuff normalizes to +/-1 tick for each wheel
event, perhaps the pixel-based value should do the same).