fix for lines (stroke) are rendered too thick (Bug 1743245) #14491
Conversation
This commit fixes Bug 1743245 (Grided PDF file lines rendered too thick) which was created by a fix for mozilla#12868 . The lineWidth was set to round(1 * this._combinedScaleFactor) when the pixel is drawn as a parallelorgam with a height <1. This fix changes this to floor(1*this._combinedScaleFactor) . This change shows a visual result comparable to Chrome and Acrobat. Regarding the last PR 3 statements in canvas.js are affected and will change with this commit (stroke and paintChar). renaming the reference files to naming comvention
quaoaris
force-pushed
the
lines-rendered-too-thick
branch
from
f81110b to
3f77d80
Compare
Snuffleupagus
requested review from
calixteman
and removed request for
Snuffleupagus
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/2732ce0e94e08ce/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/d4a5b99b62e8c37/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/2732ce0e94e08ce/output.txt Total script time: 22.98 mins
Image differences available at: http://54.241.84.105:8877/2732ce0e94e08ce/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/d4a5b99b62e8c37/output.txt Total script time: 41.79 mins
Image differences available at: http://54.193.163.58:8877/d4a5b99b62e8c37/reftest-analyzer.html#web=eq.log |
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/80af443f181f786/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/80af443f181f786/output.txt Total script time: 4.37 mins Published |
|
/botio makeref |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/79dd061ecefc8b3/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/861f78a673ab5d3/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/861f78a673ab5d3/output.txt Total script time: 20.49 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/79dd061ecefc8b3/output.txt Total script time: 37.68 mins
|
This commit fixes Bug 1743245 (Grided PDF file lines rendered too thick) which was created by a fix for #12868 .
The lineWidth was set to round(1 * this._combinedScaleFactor) when the pixel is drawn as a parallelorgam with a height <1. This fix changes this to floor(1*this._combinedScaleFactor) .
This change shows a visual result comparable to Chrome and Acrobat.
Regarding #12868 : 3 statements in canvas.js are affected and will change with this commit (stroke and paintChar).
Full tests were successfully