Skip to content

Prevent run-time errors in BaseViewer when it's falling back to SimpleLinkService (issue 14442, PR 14295 follow-up) #14443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 12, 2022

Conversation

Snuffleupagus
Copy link
Collaborator

Fixes #14442

…mpleLinkService` (issue 14442, PR 14295 follow-up)
@timvandermeij
Copy link
Contributor

/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/3e102b27701b7fe/output.txt

@timvandermeij timvandermeij reopened this Jan 12, 2022
@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/3e102b27701b7fe/output.txt

Total script time: 4.22 mins

Published

@timvandermeij timvandermeij merged commit ea57ef1 into mozilla:master Jan 12, 2022
@timvandermeij
Copy link
Contributor

Thank you for fixing this!

@Snuffleupagus Snuffleupagus deleted the issue-14442 branch January 12, 2022 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

base_viewer.js fails with this.linkService._cachedPageNumber in v2.12.313
3 participants