Skip to content

Ignore Annotations with empty /Rect-entries in the display-layer (issue 14438) #14439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 15, 2022

Conversation

Snuffleupagus
Copy link
Collaborator

This prevents the BaseSVGFactory.create-method from throwing, and thus preventing any remaining Annotations (on the page) from rendering in corrupt documents.

Fixes #14438

…ue 14438)

This prevents the `BaseSVGFactory.create`-method from throwing, and thus preventing any remaining Annotations (on the page) from rendering in corrupt documents.
@Snuffleupagus
Copy link
Collaborator Author

/botio-linux preview

@Snuffleupagus
Copy link
Collaborator Author

/botio-windows preview

@mozilla mozilla deleted a comment from pdfjsbot Jan 11, 2022
@mozilla mozilla deleted a comment from pdfjsbot Jan 11, 2022
@mozilla mozilla deleted a comment from pdfjsbot Jan 11, 2022
@mozilla mozilla deleted a comment from pdfjsbot Jan 11, 2022
@Snuffleupagus
Copy link
Collaborator Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/09573ada4a643cb/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/5daadea76db5515/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/09573ada4a643cb/output.txt

Total script time: 0.01 mins

@pdfjsbot
Copy link

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/5daadea76db5515/output.txt

Total script time: 0.02 mins

@timvandermeij
Copy link
Contributor

/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/0c9c0e6a069b4d3/output.txt

@timvandermeij
Copy link
Contributor

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_test from @timvandermeij received. Current queue size: 1

Live output at: http://54.241.84.105:8877/9c552a4ebe60013/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @timvandermeij received. Current queue size: 1

Live output at: http://54.193.163.58:8877/4c258032783ffc3/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/0c9c0e6a069b4d3/output.txt

Total script time: 4.62 mins

Published

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/9c552a4ebe60013/output.txt

Total script time: 22.97 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 8
  different first/second rendering: 3

Image differences available at: http://54.241.84.105:8877/9c552a4ebe60013/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/4c258032783ffc3/output.txt

Total script time: 41.26 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 10
  different first/second rendering: 1

Image differences available at: http://54.193.163.58:8877/4c258032783ffc3/reftest-analyzer.html#web=eq.log

@timvandermeij timvandermeij merged commit a72d188 into mozilla:master Jan 15, 2022
@timvandermeij
Copy link
Contributor

Thank you for fixing this!

@Snuffleupagus Snuffleupagus deleted the issue-14438 branch January 15, 2022 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

some code error?
3 participants