Consistently use string arguments for page.waitForFunction calls and upgrade to Puppeteer 13.0.0 #14368
Conversation
We use string arguments in all other places, so these two places are a bit inconsistent in that sense. Moreover, it's just one argument now, which makes it a bit easier to read and see what it does because we don't have to pass the always-empty options argument anymore. Finally, doing it like this ensures it works in all Puppeteer versions given puppeteer/puppeteer#7836.
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/4502d7bdbd53cd0/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/b4099bee29e23aa/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/4502d7bdbd53cd0/output.txt Total script time: 23.02 mins
Image differences available at: http://54.241.84.105:8877/4502d7bdbd53cd0/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/b4099bee29e23aa/output.txt Total script time: 42.23 mins
Image differences available at: http://54.193.163.58:8877/b4099bee29e23aa/reftest-analyzer.html#web=eq.log |
|
/botio integrationtest |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/c243cc055188428/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/9f92d6c4f86905c/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/9f92d6c4f86905c/output.txt Total script time: 3.82 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/c243cc055188428/output.txt Total script time: 5.95 mins
|
The commit messages contain more information about the individual changes.
This commit makes sure that our code is consistent and avoids the issue now reported upstream in puppeteer/puppeteer#7836 so that it's no longer a blocker for us.
Fixes #14363.