Only call PDFDocumentProxy.getPermissions, in the viewer, when pdfjs.enablePermissions is set (PR 14362 follow-up)
#14364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snuffleupagus
force-pushed
the
BaseViewer-conditional-getPermissions
branch
from
890e181 to
63af15e
Compare
…js.enablePermissions` is set (PR 14362 follow-up) By making this API-call *unconditionally*, we introduce a (slight) delay in the initialization of *all* documents. That seems quite unfortunate, since `pdfjs.enablePermissions` is off by default, and it thus seem better only do the API-call when actually needed; sorry about this!
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/2cf7388c3260fcf/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/2cf7388c3260fcf/output.txt Total script time: 4.31 mins Published |
timvandermeij
approved these changes
Dec 12, 2021
|
Good point; even though it's a minor delay, it's better to avoid it. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By making this API-call unconditionally, we introduce a (slight) delay in the initialization of all documents.
That seems quite unfortunate, since
pdfjs.enablePermissionsis off by default, and it thus seem better only do the API-call when actually needed; sorry about this!