Change WorkerTransport.{pageCache, pagePromises} from an Array to a Map
#14355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given that not all pages necessarily are being accessed, or that the pages may be accessed out of order, using a `Map` seems like a more appropriate data-structure here. For one thing, this simplifies iteration since we no longer have to worry about/check if `pageCache`-entries are undefined (which will happen for *sparse* `Array`s). Of particular note is that we're no longer attempting to "null" the `pageCache`-entry from within the `PDFPageProxy._destroy`-method. Given that *synchronous* JavaScript will always run to completion[1] and that we're looping through all pages in `WorkerTransport.destroy` and immediately clear the cache afterwards, that code did/does not really make a lot of sense (as far as I can tell). Finally, also changes the `pageCache` to a *private* property since it's not supposed to be accessed from the "outside". --- [1] Unless there are errors, of course.
Given that not all pages necessarily are being accessed, or that the pages may be accessed out of order, using a `Map` seems like a more appropriate data-structure here. Finally, also changes the `pagePromises` to a *private* property since it's not supposed to be accessed from the "outside".
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/d265567a867b1e3/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/0fe5f0fdbf1ceaf/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/d265567a867b1e3/output.txt Total script time: 21.80 mins
Image differences available at: http://54.241.84.105:8877/d265567a867b1e3/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/0fe5f0fdbf1ceaf/output.txt Total script time: 41.68 mins
Image differences available at: http://54.193.163.58:8877/0fe5f0fdbf1ceaf/reftest-analyzer.html#web=eq.log |
timvandermeij
approved these changes
Dec 11, 2021
|
Looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
WorkerTransport.pageCachefrom an Array to a MapGiven that not all pages necessarily are being accessed, or that the pages may be accessed out of order, using a
Mapseems like a more appropriate data-structure here.For one thing, this simplifies iteration since we no longer have to worry about/check if
pageCache-entries are undefined (which will happen for sparseArrays).Of particular note is that we're no longer attempting to "null" the
pageCache-entry from within thePDFPageProxy._destroy-method. Given that synchronous JavaScript will always run to completion[1] and that we're looping through all pages inWorkerTransport.destroyand immediately clear the cache afterwards, that code did/does not really make a lot of sense (as far as I can tell).Finally, also changes the
pageCacheto a private property since it's not supposed to be accessed from the "outside".[1] Unless there are errors, of course.
Change
WorkerTransport.pagePromisesfrom an Array to a MapGiven that not all pages necessarily are being accessed, or that the pages may be accessed out of order, using a
Mapseems like a more appropriate data-structure here.Finally, also changes the
pagePromisesto a private property since it's not supposed to be accessed from the "outside".