Ensure that the viewer handles BaseViewer initialization failures
#14345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*This patch can be tested e.g. with the `poppler-85140-0.pdf` document from the test-suite.*
For some sufficiently corrupt documents the `getDocument` call will succeed, but fetching even the very first page fails. Currently we only print error messages (in the console) from the `{BaseViewer, PDFThumbnailViewer}.setDocument` methods, but don't actually provide these errors to allow the viewer to handle them properly.
In practice this means that the GENERIC viewer won't display the `errorWrapper`, and in the MOZCENTRAL viewer the *browser* loading indicator is never hidden (since we never unblock the "load" event).
These changes improves the consistency ever so slightly in the `PDFOutlineViewer._dispatchEvent` method, by making sure that we can tell the following two cases apart: - The "pagesloaded" event has *not yet* been fired. - The "pagesloaded" event has been fired, but no pages were available.
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/4594d98590a7fe4/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/4594d98590a7fe4/output.txt Total script time: 4.34 mins Published |
timvandermeij
approved these changes
Dec 5, 2021
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch can be tested e.g. with the
poppler-85140-0.pdfdocument from the test-suite.For some sufficiently corrupt documents the
getDocumentcall will succeed, but fetching even the very first page fails. Currently we only print error messages (in the console) from the{BaseViewer, PDFThumbnailViewer}.setDocumentmethods, but don't actually provide these errors to allow the viewer to handle them properly.In practice this means that the GENERIC viewer won't display the
errorWrapper, and in the MOZCENTRAL viewer the browser loading indicator is never hidden (since we never unblock the "load" event).