Skip to content

Add a (linked) test-case for issue 8019 #14339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 4, 2021

Conversation

Snuffleupagus
Copy link
Collaborator

Given that bug 1336572 was just closed as fixed, thus fixing issue #8019 in Firefox[1], let's add a test-case to enable us to catch any future regressions either in PDF.js or in browsers themselves.


[1] It also seems to be working in Google Chrome, although I'm having a slightly difficult time deciphering exactly what configurations were affected when looking through issue #8019.

Given that [bug 1336572](https://bugzilla.mozilla.org/show_bug.cgi?id=1336572) was just closed as fixed, thus fixing issue 8019 in Firefox[1], let's add a test-case to enable us to catch any future regressions either in PDF.js or in browsers themselves.

---
[1] It also seems to be working in Google Chrome, although I'm having a slightly difficult time deciphering *exactly* what configurations were affected when looking through issue 8019.
@Snuffleupagus
Copy link
Collaborator Author

/botio browsertest

@pdfjsbot
Copy link

pdfjsbot commented Dec 4, 2021

From: Bot.io (Windows)


Received

Command cmd_browsertest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/b99e6ed5ad19898/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Dec 4, 2021

From: Bot.io (Linux m4)


Received

Command cmd_browsertest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/b68e0d5ecbd9342/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Dec 4, 2021

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/b68e0d5ecbd9342/output.txt

Total script time: 19.21 mins

  • Regression tests: FAILED
  different ref/snapshot: 6
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/b68e0d5ecbd9342/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

pdfjsbot commented Dec 4, 2021

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/b99e6ed5ad19898/output.txt

Total script time: 37.69 mins

  • Regression tests: FAILED
  different ref/snapshot: 12
  different first/second rendering: 2

Image differences available at: http://54.193.163.58:8877/b99e6ed5ad19898/reftest-analyzer.html#web=eq.log

@timvandermeij timvandermeij merged commit dc455c8 into mozilla:master Dec 4, 2021
@timvandermeij
Copy link
Contributor

Good idea!

/botio makeref

@pdfjsbot
Copy link

pdfjsbot commented Dec 4, 2021

From: Bot.io (Linux m4)


Received

Command cmd_makeref from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/81d8424fa2390fb/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Dec 4, 2021

From: Bot.io (Windows)


Received

Command cmd_makeref from @timvandermeij received. Current queue size: 3

Live output at: http://54.193.163.58:8877/6f0759485f9b34f/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Dec 4, 2021

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/81d8424fa2390fb/output.txt

Total script time: 19.91 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

pdfjsbot commented Dec 4, 2021

From: Bot.io (Windows)


Success

Full output at http://54.193.163.58:8877/6f0759485f9b34f/output.txt

Total script time: 38.51 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@Snuffleupagus Snuffleupagus deleted the issue-8019-reftest branch December 4, 2021 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants