Skip to content

Update packages and translations #14320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 28, 2021

Conversation

Snuffleupagus
Copy link
Collaborator

No description provided.

@Snuffleupagus
Copy link
Collaborator Author

Given that I don't really know TypeScript, and don't have time to try and figure out why updating it didn't just work, I've settled on simply pinning the version number for now. (We really need TypeScript users to help handle these things...)

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/97353cab392195b/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/0c2a240eb99251d/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/97353cab392195b/output.txt

Total script time: 21.87 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 10
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/97353cab392195b/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/0c2a240eb99251d/output.txt

Total script time: 41.88 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 6
  different first/second rendering: 1

Image differences available at: http://54.193.163.58:8877/0c2a240eb99251d/reftest-analyzer.html#web=eq.log

@Snuffleupagus
Copy link
Collaborator Author

/botio lint

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_lint from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/31e2bac007c1f38/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_lint from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/e78f94f3e1db867/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/31e2bac007c1f38/output.txt

Total script time: 2.29 mins

  • Lint: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://54.193.163.58:8877/e78f94f3e1db867/output.txt

Total script time: 3.92 mins

  • Lint: Passed

@timvandermeij timvandermeij merged commit 7613bb5 into mozilla:master Nov 28, 2021
@timvandermeij
Copy link
Contributor

Thank you for the updates!

@Snuffleupagus Snuffleupagus deleted the update-packages branch November 28, 2021 13:07
@Snuffleupagus
Copy link
Collaborator Author

@timvandermeij Do you perhaps have any idea, or maybe time to look into, why updating Puppeteer to the latest versions fail?

Awhile back I tried to update to version 11, and today I tried version 12 as well, but this causes testing in Firefox to break locally. More specifically, when running e.g. the unit-tests Firefox no longer shuts down at the end of the tests.

I've been looking at https://github.com/puppeteer/puppeteer/releases/, but I'm not able to tell what (if anything) we need to change in our code to be compatible with the new versions.

@timvandermeij
Copy link
Contributor

timvandermeij commented Nov 28, 2021

Hm, good question; I don't see anything particularly suspicious in the changelog. I'll try to test it out today and hopefully reproduce it on Linux (since it may even be OS-specific, which I don't hope...).

@timvandermeij
Copy link
Contributor

timvandermeij commented Nov 28, 2021

I can now reproduce the issue with Puppeteer 11 on Linux too. This required much more effort than I hoped since my system's Node.js version got updated to version 17 and all of sudden Firefox wouldn't start at all anymore. After a lot of debugging and searching I found that the Node.js developers made a breaking change in version 17 (and people don't seem all too happy about it in the upstream issues I'm reading). Fortunately there is a configuration option to default back to the "old" working behavior, so I'll prepare a PR for that once I also (hopefully) get Puppeteer 11+ working.

@Snuffleupagus
Copy link
Collaborator Author

Snuffleupagus commented Nov 28, 2021

This required much more effort than I hoped since my system's Node.js version got updated to version 17 and all of sudden Firefox wouldn't start at all anymore.

Oof, that sounds "fun".
Locally I'm still on Node 12, which seem to be generally supported across all(?) npm packages, which is why I'm suspecting that something must have changed in Puppeteer as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants