-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Update packages and translations #14320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f948370
to
37bed4e
Compare
Given that I don't really know TypeScript, and don't have time to try and figure out why updating it didn't just work, I've settled on simply pinning the version number for now. (We really need TypeScript users to help handle these things...) /botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/97353cab392195b/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/0c2a240eb99251d/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/97353cab392195b/output.txt Total script time: 21.87 mins
Image differences available at: http://54.241.84.105:8877/97353cab392195b/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/0c2a240eb99251d/output.txt Total script time: 41.88 mins
Image differences available at: http://54.193.163.58:8877/0c2a240eb99251d/reftest-analyzer.html#web=eq.log |
Based on https://github.com/stylelint/stylelint/blob/14.0.0/docs/migration-guide/to-14.md none of the changes look directly relevant for us.
/botio lint |
From: Bot.io (Linux m4)ReceivedCommand cmd_lint from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/31e2bac007c1f38/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_lint from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/e78f94f3e1db867/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/31e2bac007c1f38/output.txt Total script time: 2.29 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/e78f94f3e1db867/output.txt Total script time: 3.92 mins
|
Thank you for the updates! |
@timvandermeij Do you perhaps have any idea, or maybe time to look into, why updating Puppeteer to the latest versions fail? Awhile back I tried to update to version 11, and today I tried version 12 as well, but this causes testing in Firefox to break locally. More specifically, when running e.g. the unit-tests Firefox no longer shuts down at the end of the tests. I've been looking at https://github.com/puppeteer/puppeteer/releases/, but I'm not able to tell what (if anything) we need to change in our code to be compatible with the new versions. |
Hm, good question; I don't see anything particularly suspicious in the changelog. I'll try to test it out today and hopefully reproduce it on Linux (since it may even be OS-specific, which I don't hope...). |
I can now reproduce the issue with Puppeteer 11 on Linux too. This required much more effort than I hoped since my system's Node.js version got updated to version 17 and all of sudden Firefox wouldn't start at all anymore. After a lot of debugging and searching I found that the Node.js developers made a breaking change in version 17 (and people don't seem all too happy about it in the upstream issues I'm reading). Fortunately there is a configuration option to default back to the "old" working behavior, so I'll prepare a PR for that once I also (hopefully) get Puppeteer 11+ working. |
Oof, that sounds "fun". |
No description provided.