Replace the remaining Node.removeChild() instances with Element.remove()
#14278
Conversation
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/ce903bed515ba22/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/f0a974663d2ecae/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/f0a974663d2ecae/output.txt Total script time: 23.77 mins
Image differences available at: http://54.241.84.105:8877/f0a974663d2ecae/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/ce903bed515ba22/output.txt Total script time: 42.04 mins
Image differences available at: http://54.193.163.58:8877/ce903bed515ba22/reftest-analyzer.html#web=eq.log |
|
@Snuffleupagus You can activate the eslint rule |
Snuffleupagus
force-pushed
the
rm-removeChild
branch
2 times, most recently
from
fcaaf19 to
4d37a03
Compare
…move()` Using `Element.remove()` is a slightly more compact way of removing an element, since you no longer need to explicitly find/use its parent element. Furthermore, the patch also replaces a couple of loops that're used to delete all elements under a node with simply overwriting the contents directly (a pattern already used throughout the viewer). See also: - https://developer.mozilla.org/en-US/docs/Web/API/Node/removeChild - https://developer.mozilla.org/en-US/docs/Web/API/Element/remove
Snuffleupagus
force-pushed
the
rm-removeChild
branch
from
4d37a03 to
4e2c2fa
Compare
|
Nice work; thanks both! |
Using
Element.remove()is a slightly more compact way of removing an element, since you no longer need to explicitly find/use its parent element.Furthermore, the patch also replaces a couple of loops that're used to delete all elements under a node with simply overwriting the contents directly (a pattern already used throughout the viewer).
See also: