-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Don't consider space as real space when there is an extra spacing (bug 931481) #14266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
calixteman
commented
Nov 12, 2021
- it aims to fix https://bugzilla.mozilla.org/show_bug.cgi?id=931481;
- real space chars are pushed in the chunk but when there is an extra spacing, the next char position must be compared with the previous one;
- for example, an extra spacing can cancel a space so visually there are no space.
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/3cb3b8bcac5d81e/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/b3c8ee33a48b6c1/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/3cb3b8bcac5d81e/output.txt Total script time: 3.07 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/b3c8ee33a48b6c1/output.txt Total script time: 5.56 mins
|
…g 931481) - it aims to fix https://bugzilla.mozilla.org/show_bug.cgi?id=931481; - real space chars are pushed in the chunk but when there is an extra spacing, the next char position must be compared with the previous one; - for example, an extra spacing can cancel a space so visually there are no space.
d86b3f9
to
a88ff34
Compare
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/3e6761acda780d7/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/1c12c894d529807/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/3e6761acda780d7/output.txt Total script time: 23.76 mins
Image differences available at: http://54.241.84.105:8877/3e6761acda780d7/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/1c12c894d529807/output.txt Total script time: 41.96 mins
Image differences available at: http://54.193.163.58:8877/1c12c894d529807/reftest-analyzer.html#web=eq.log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me, thank you!
/botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/b7cb4e93a365f5a/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 1 Live output at: http://54.193.163.58:8877/33996ef584f93bd/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/b7cb4e93a365f5a/output.txt Total script time: 21.71 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/33996ef584f93bd/output.txt Total script time: 38.69 mins
|