Always prefer abbreviated keys, over full ones, when doing any dictionary lookups (issue 14256) #14258
Conversation
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/77670f9e95cb178/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/77670f9e95cb178/output.txt Total script time: 4.45 mins Published |
Snuffleupagus
force-pushed
the
issue-14256-2
branch
from
77e202e to
79eb4da
Compare
…nary lookups (issue 14256) Note that issue 14256 was specifically about *inline* images, please refer to: - https://www.adobe.com/content/dam/acom/en/devnet/pdf/pdfs/PDF32000_2008.pdf#G7.1852045 - https://www.pdfa.org/safedocs-unearths-pdf-inline-image-issue/ - https://pdf-issues.pdfa.org/32000-2-2020/clause08.html#H8.9.7 However, during review of the initial PR in mozilla#14257 (comment), it was suggested that we instead do this *unconditionally for all* dictionary lookups. In addition to re-ordering the existing call-sites in the `src/core`-code, and adding non-PRODUCTION/TESTING asserts to catch future errors, for consistency a number of existing `if`/`switch`-blocks were re-factored to also check the abbreviated keys first.
Snuffleupagus
force-pushed
the
issue-14256-2
branch
from
79eb4da to
ea1c348
Compare
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/34b9e1b40f7e94f/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/25d013c12594004/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/34b9e1b40f7e94f/output.txt Total script time: 23.68 mins
Image differences available at: http://54.241.84.105:8877/34b9e1b40f7e94f/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/25d013c12594004/output.txt Total script time: 41.71 mins
Image differences available at: http://54.193.163.58:8877/25d013c12594004/reftest-analyzer.html#web=eq.log |
|
/botio makeref Looks good, thanks! |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @brendandahl received. Current queue size: 0 Live output at: http://54.241.84.105:8877/965515d1af7a598/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @brendandahl received. Current queue size: 0 Live output at: http://54.193.163.58:8877/df03123f29a29ad/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/965515d1af7a598/output.txt Total script time: 21.38 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/df03123f29a29ad/output.txt Total script time: 38.51 mins
|
Note that issue #14256 was specifically about inline images, please refer to:
However, during review of the initial PR in #14257 (comment), it was suggested that we instead do this unconditionally for all dictionary lookups.
In addition to re-ordering the existing call-sites in the
src/core-code, and adding non-PRODUCTION/TESTING asserts to catch future errors, for consistency a number of existingif/switch-blocks were re-factored to also check the abbreviated keys first.