Convert GrabToPan to a standard class
#14255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timvandermeij
approved these changes
Nov 13, 2021
Given the support information listed in the function itself, the [MDN compatibility data](https://developer.mozilla.org/en-US/docs/Web/API/MouseEvent/buttons#browser_compatibility), and the [currently supported browsers](https://github.com/mozilla/pdf.js/blob/4bb9de4b008dca2cdccf770bc359ae21971debb0/gulpfile.js#L79-L87) in the PDF.js project we should be able to simplify the code by inlining the function instead.
This code is the last piece[1] of the viewer that's not using standard `class`es, and by converting this code we get rid of some now unneeded boilerplate code (slightly reducing the size of the *built* `web/viewer.js` file). Note that while this code was originally imported from a separate repository, it was last sync-ed with upstream *five years* ago which is why this re-factoring should be OK as far as I'm concerned (and we've done some other clean-up since then as well). --- [1] Technically the `web/debugger.js` file is left as well, however that code is first of all not bundled in the *built* `web/viewer.js` file and secondly it's not even loaded by default either.
Snuffleupagus
force-pushed
the
GrabToPan-class
branch
from
b36e4f8 to
08d56c6
Compare
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/3c361148c796d8c/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/3c361148c796d8c/output.txt Total script time: 4.49 mins Published |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[web/grab_to_pan.js] Inline the
isLeftMouseReleasedhelper functionGiven the support information listed in the function itself, the MDN compatibility data, and the currently supported browsers in the PDF.js project we should be able to simplify the code by inlining the function instead.
Convert
GrabToPanto a standardclassThis code is the last piece[1] of the viewer that's not using standard
classes, and by converting this code we get rid of some now unneeded boilerplate code (slightly reducing the size of the builtweb/viewer.jsfile).Note that while this code was originally imported from a separate repository, it was last sync-ed with upstream five years ago which is why this re-factoring should be OK as far as I'm concerned (and we've done some other clean-up since then as well).
[1] Technically the
web/debugger.jsfile is left as well, however that code is first of all not bundled in the builtweb/viewer.jsfile and secondly it's not even loaded by default either.