Prevent mobile devices from interfering with the textLayer-elements (issue 14243) #14244
Conversation
…issue 14243) *This is a tentative patch, since I don't have the necessary hardware to test it.* See https://developer.mozilla.org/en-US/docs/Web/CSS/text-size-adjust, which is currently ignored in Firefox. It seems overall safer, and more future-proof, to simply add this to the *entire* `textLayer` rather than its individual elements.
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/6ca1a9dbdc089cd/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/6ca1a9dbdc089cd/output.txt Total script time: 5.31 mins Published |
|
@Snuffleupagus Does this automatically add the prefixed version? The unprefixed version is not recognised by iOS Safari. |
Of course, which is clear if you look at the generated file: http://54.241.84.105:8877/6ca1a9dbdc089cd/web/viewer.css |
|
I have tested this with Firefox Nightly on Android and found no difference before/after, which is good because as the bug report mentioned this seems to only affect iOS devices. I don't have such a device to confirm this works. @shivaprsd Could you test the preview link above and see if that fixes the issue? |
|
@timvandermeij I can confirm that it fixes the issue in Viewer (legacy). 👍🏼 |
|
Thanks! |
This is a tentative patch, since I don't have the necessary hardware to test it.
See https://developer.mozilla.org/en-US/docs/Web/CSS/text-size-adjust, which is currently ignored in Firefox.
It seems overall safer, and more future-proof, to simply add this to the entire
textLayerrather than its individual elements.Fixes #14243