Don't double apply a group xobject's bbox. #14241
Conversation
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @brendandahl received. Current queue size: 0 Live output at: http://54.241.84.105:8877/9b51eeed82fb3c1/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @brendandahl received. Current queue size: 1 Live output at: http://54.193.163.58:8877/1c4661691995242/output.txt |
There was a problem hiding this comment.
Should we perhaps change this to an "eq"-test instead?
pdf.js/test/test_manifest.json
Line 5925 in 30bd5f0
r=me, with passing (or improving) tests; thank you!
Yes! |
brendandahl
force-pushed
the
group-bbox-matrix
branch
from
f76cac8 to
9085194
Compare
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/9b51eeed82fb3c1/output.txt Total script time: 23.35 mins
Image differences available at: http://54.241.84.105:8877/9b51eeed82fb3c1/reftest-analyzer.html#web=eq.log |
In `beginGroup` we create a new canvas that is the size of the bounding box and we translate it to the offset. This means we don't need to also apply the bounding box during `paintFormXObjectBegin`. This improves mozilla#6961 quite a bit, but it still is missing the indention in the ruler.
brendandahl
force-pushed
the
group-bbox-matrix
branch
from
9085194 to
8161d3f
Compare
brendandahl
changed the title
|
This should fix /botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @brendandahl received. Current queue size: 1 Live output at: http://54.241.84.105:8877/5ee14ee0a9055e2/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @brendandahl received. Current queue size: 2 Live output at: http://54.193.163.58:8877/e9070e6339fe117/output.txt |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/1c4661691995242/output.txt Total script time: 42.55 mins
Image differences available at: http://54.193.163.58:8877/1c4661691995242/reftest-analyzer.html#web=eq.log |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/5ee14ee0a9055e2/output.txt Total script time: 23.47 mins
Image differences available at: http://54.241.84.105:8877/5ee14ee0a9055e2/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/e9070e6339fe117/output.txt Total script time: 42.27 mins
Image differences available at: http://54.193.163.58:8877/e9070e6339fe117/reftest-analyzer.html#web=eq.log |
|
/botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @brendandahl received. Current queue size: 0 Live output at: http://54.241.84.105:8877/18f6f0adf14a89e/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @brendandahl received. Current queue size: 0 Live output at: http://54.193.163.58:8877/c2bbf7b37c42713/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/18f6f0adf14a89e/output.txt Total script time: 19.31 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/c2bbf7b37c42713/output.txt Total script time: 38.55 mins
|
|
/botio-linux makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/6e03bdc06090944/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/6e03bdc06090944/output.txt Total script time: 20.89 mins
|
In
beginGroupwe create a new canvas that is the size of thebounding box and we translate it to the offset. This means we don't need to
also apply the bounding box during
paintFormXObjectBegin.This improves #6961 quite a bit, but it still is missing the indention
in the ruler.