Skip to content

XFA - Get each page asynchronously in order to avoid blocking the event loop (#14014) #14240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 6, 2021
Merged

XFA - Get each page asynchronously in order to avoid blocking the event loop (#14014) #14240

merged 1 commit into from
Nov 6, 2021

Conversation

calixteman
Copy link
Contributor

No description provided.

@calixteman
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Nov 5, 2021

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/b68c5085de5fbc1/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Nov 5, 2021

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/83a3803c9eddf5b/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Nov 5, 2021

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/b68c5085de5fbc1/output.txt

Total script time: 23.39 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 11
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/b68c5085de5fbc1/reftest-analyzer.html#web=eq.log

Snuffleupagus
Snuffleupagus requested changes Nov 5, 2021
View reviewed changes
@pdfjsbot
Copy link

pdfjsbot commented Nov 5, 2021

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/83a3803c9eddf5b/output.txt

Total script time: 42.06 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 9
  different first/second rendering: 1

Image differences available at: http://54.193.163.58:8877/83a3803c9eddf5b/reftest-analyzer.html#web=eq.log

@calixteman
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Nov 5, 2021

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/572d1cfaf0a9ad1/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Nov 5, 2021

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/a681e07e52d9602/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Nov 5, 2021

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/572d1cfaf0a9ad1/output.txt

Total script time: 23.44 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 8
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/572d1cfaf0a9ad1/reftest-analyzer.html#web=eq.log

@calixteman
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Nov 5, 2021

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/7d078fffdb96651/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Nov 5, 2021

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 1

Live output at: http://54.193.163.58:8877/3bdccd61c321b9b/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Nov 5, 2021

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/a681e07e52d9602/output.txt

Total script time: 42.50 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 10
  different first/second rendering: 3

Image differences available at: http://54.193.163.58:8877/a681e07e52d9602/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

pdfjsbot commented Nov 5, 2021

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/7d078fffdb96651/output.txt

Total script time: 23.39 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 11
  different first/second rendering: 2

Image differences available at: http://54.241.84.105:8877/7d078fffdb96651/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

pdfjsbot commented Nov 5, 2021

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/3bdccd61c321b9b/output.txt

Total script time: 42.30 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 7
  different first/second rendering: 2

Image differences available at: http://54.193.163.58:8877/3bdccd61c321b9b/reftest-analyzer.html#web=eq.log

@calixteman
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Nov 5, 2021

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/6cd4acebfc282ef/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Nov 5, 2021

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 1

Live output at: http://54.193.163.58:8877/58ab654140f7234/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Nov 5, 2021

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/6cd4acebfc282ef/output.txt

Total script time: 23.44 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 13

Image differences available at: http://54.241.84.105:8877/6cd4acebfc282ef/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

pdfjsbot commented Nov 5, 2021

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/58ab654140f7234/output.txt

Total script time: 42.31 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 9
  different first/second rendering: 1

Image differences available at: http://54.193.163.58:8877/58ab654140f7234/reftest-analyzer.html#web=eq.log

@calixteman
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Nov 6, 2021

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/578aa1fa3a92cc8/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Nov 6, 2021

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/90ea0838a20f7fb/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Nov 6, 2021

From: Bot.io (Windows)

Received

Command cmd_xfatest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/dd96d9ce7a8c80c/output.txt

@calixteman
Copy link
Contributor Author

No more test failures for the moment.
I don't know if it'll fix the test issues but it likely doesn't hurt to have this patch.
Once everything is ok, we can merge it and see for its positive effects on CI in the next days.
/botio test

@pdfjsbot
Copy link

pdfjsbot commented Nov 6, 2021

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 1

Live output at: http://54.241.84.105:8877/8058b754d05b6d5/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Nov 6, 2021

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 1

Live output at: http://54.193.163.58:8877/7be1e71d2e23feb/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Nov 6, 2021

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/7fd0fbce8a4e2a7/output.txt

Total script time: 9.60 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 2

Image differences available at: http://54.241.84.105:8877/7fd0fbce8a4e2a7/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

pdfjsbot commented Nov 6, 2021

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/dd96d9ce7a8c80c/output.txt

Total script time: 16.91 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 2

Image differences available at: http://54.193.163.58:8877/dd96d9ce7a8c80c/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

pdfjsbot commented Nov 6, 2021

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/8058b754d05b6d5/output.txt

Total script time: 23.20 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 8
  different first/second rendering: 2

Image differences available at: http://54.241.84.105:8877/8058b754d05b6d5/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

pdfjsbot commented Nov 6, 2021

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/7be1e71d2e23feb/output.txt

Total script time: 41.38 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 10
  different first/second rendering: 1

Image differences available at: http://54.193.163.58:8877/7be1e71d2e23feb/reftest-analyzer.html#web=eq.log

@Snuffleupagus
Copy link
Collaborator

/botio xfatest

@pdfjsbot
Copy link

pdfjsbot commented Nov 6, 2021

From: Bot.io (Linux m4)

Received

Command cmd_xfatest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/dd34e1232833a22/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Nov 6, 2021

From: Bot.io (Windows)

Received

Command cmd_xfatest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/54f950ac9a3f78b/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Nov 6, 2021

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/dd34e1232833a22/output.txt

Total script time: 9.61 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 2

Image differences available at: http://54.241.84.105:8877/dd34e1232833a22/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

pdfjsbot commented Nov 6, 2021

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/54f950ac9a3f78b/output.txt

Total script time: 16.76 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 2

Image differences available at: http://54.193.163.58:8877/54f950ac9a3f78b/reftest-analyzer.html#web=eq.log

@calixteman
Copy link
Contributor Author

/botio xfatest

@pdfjsbot
Copy link

pdfjsbot commented Nov 6, 2021

From: Bot.io (Linux m4)

Received

Command cmd_xfatest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/577041f18bc97ca/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Nov 6, 2021

From: Bot.io (Windows)

Received

Command cmd_xfatest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/e8ceb30a045a090/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Nov 6, 2021

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/577041f18bc97ca/output.txt

Total script time: 9.64 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 1

Image differences available at: http://54.241.84.105:8877/577041f18bc97ca/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

pdfjsbot commented Nov 6, 2021

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/e8ceb30a045a090/output.txt

Total script time: 16.63 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 3

Image differences available at: http://54.193.163.58:8877/e8ceb30a045a090/reftest-analyzer.html#web=eq.log

@Snuffleupagus
Copy link
Collaborator

/botio xfatest

@pdfjsbot
Copy link

pdfjsbot commented Nov 6, 2021

From: Bot.io (Linux m4)

Received

Command cmd_xfatest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/fad8536f863dcd6/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Nov 6, 2021

From: Bot.io (Windows)

Received

Command cmd_xfatest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/0854729e8482adf/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Nov 6, 2021

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/fad8536f863dcd6/output.txt

Total script time: 9.65 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 1

Image differences available at: http://54.241.84.105:8877/fad8536f863dcd6/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

pdfjsbot commented Nov 6, 2021

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/0854729e8482adf/output.txt

Total script time: 16.53 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 3

Image differences available at: http://54.193.163.58:8877/0854729e8482adf/reftest-analyzer.html#web=eq.log

Snuffleupagus
Snuffleupagus approved these changes Nov 6, 2021
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It certainly seems like this have helped, since there's not been any intermittent failures so far.
This only leaves one thing, trying to explain why exactly this actually worked :-)

r=me, since this doesn't really effect anything except the XFA-code now; thank you!

@Snuffleupagus Snuffleupagus linked an issue Nov 6, 2021 that may be closed by this pull request
Intermittent bug with XFA test on the bots #14014
Closed
@calixteman calixteman merged commit efb4455 into mozilla:master Nov 6, 2021
@calixteman calixteman deleted the 14014 branch November 6, 2021 20:21
@calixteman
Copy link
Contributor Author

I really hope those intermittents are fixed: crossed fingers...

@marco-c
Copy link
Contributor

marco-c commented Nov 7, 2021

\o/

@timvandermeij timvandermeij removed the request for review from brendandahl November 7, 2021 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees
No one assigned
Labels
form-xfa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Intermittent bug with XFA test on the bots
5 participants
@calixteman @pdfjsbot @Snuffleupagus @marco-c @timvandermeij