-
Notifications
You must be signed in to change notification settings - Fork 10.3k
XFA - Fix a breakBefore issue when target is a contentArea and startNew is 1 (bug 1739502) #14239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
calixteman
commented
Nov 5, 2021
- it aims to fix https://bugzilla.mozilla.org/show_bug.cgi?id=1739502;
- when the target area was the current content area, everything was pushed in it instead of creating a new one (and consequently a new pageArea is created).
- the pdf shows an alignment issue on page 4:
- the hAlign is "center" but the subform was the width of its parent, so compute the real width of the subform with tb layout;
- there is an extra empty page at the end of the pdf:
- there is a subform with some hidden elements which are not rendered for now (since there is no plugged JS engine it isn't possible to draw them in changing their visibility).
- so in case a subform is empty and has no real dimensions (at least one is 0), we just consider it as empty.
…ew is 1 (bug 1739502) - it aims to fix https://bugzilla.mozilla.org/show_bug.cgi?id=1739502; - when the target area was the current content area, everything was pushed in it instead of creating a new one (and consequently a new pageArea is created). - the pdf shows an alignment issue on page 4: - the hAlign is "center" but the subform was the width of its parent, so compute the real width of the subform with tb layout; - there is an extra empty page at the end of the pdf: - there is a subform with some hidden elements which are not rendered for now (since there is no plugged JS engine it isn't possible to draw them in changing their visibility). - so in case a subform is empty and has no real dimensions (at least one is 0), we just consider it as empty.
/botio xfatest |
From: Bot.io (Linux m4)ReceivedCommand cmd_xfatest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/a2b108c3fd0cd4b/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_xfatest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/a4e7faeff2ee077/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/a2b108c3fd0cd4b/output.txt Total script time: 9.87 mins
Image differences available at: http://54.241.84.105:8877/a2b108c3fd0cd4b/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/a4e7faeff2ee077/output.txt Total script time: 14.31 mins
Image differences available at: http://54.193.163.58:8877/a4e7faeff2ee077/reftest-analyzer.html#web=eq.log |
/botio xfatest |
From: Bot.io (Linux m4)ReceivedCommand cmd_xfatest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/e3d34bbc70b597d/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_xfatest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/6b097944e69f7bb/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/e3d34bbc70b597d/output.txt Total script time: 9.67 mins
Image differences available at: http://54.241.84.105:8877/e3d34bbc70b597d/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/6b097944e69f7bb/output.txt Total script time: 17.10 mins
Image differences available at: http://54.193.163.58:8877/6b097944e69f7bb/reftest-analyzer.html#web=eq.log |
/botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/733a063312d3566/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/0740eda683bb439/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/733a063312d3566/output.txt Total script time: 21.28 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/0740eda683bb439/output.txt Total script time: 38.24 mins
|