Add a couple of basic unit-tests for PDFPageViewBuffer
#14238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/62939e072d66b06/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/2cfcd293e4f043f/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/62939e072d66b06/output.txt Total script time: 2.93 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/2cfcd293e4f043f/output.txt Total script time: 6.06 mins
|
The `PDFPageViewBuffer`-code is very important for the correct function of the viewer, but it's currently not tested at all. While the `PDFPageViewBuffer` is obviously intended to be used with `PDFPageView`-instances, it only accesses a couple of `PDFPageView` properties/methods and consequently it's fairly easy to unit-test this code with dummy-data. These unit-tests should help improve our confidence in this code, and will also come in handy with other changes that I'm working on (regarding modernizing and re-factoring the `PDFPageViewBuffer`-code).
Snuffleupagus
force-pushed
the
PDFPageViewBuffer-tests
branch
from
12fd504 to
fe205ef
Compare
timvandermeij
approved these changes
Nov 5, 2021
|
It's great to have more unit test for the viewer logic; thank you for doing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
PDFPageViewBuffer-code is very important for the correct function of the viewer, but it's currently not tested at all.While the
PDFPageViewBufferis obviously intended to be used withPDFPageView-instances, it only accesses a couple ofPDFPageViewproperties/methods and consequently it's fairly easy to unit-test this code with dummy-data.These unit-tests should help improve our confidence in this code, and will also come in handy with other changes that I'm working on (regarding modernizing and re-factoring the
PDFPageViewBuffer-code).