Skip to content

Use correct matrix for patterns with showText. #14232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 5, 2021
Merged

Use correct matrix for patterns with showText. #14232

merged 1 commit into from
Nov 5, 2021

Conversation

brendandahl
Copy link
Contributor

We were incorrectly using the transform in the pattern before it had been
adjusted causing the pattern to be misplaced relative to the page.

Fixes: ShowText-ShadingPattern.pdf (already in corpus)
Fixes: #8111
Fixes: #9243

@brendandahl
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Nov 4, 2021

From: Bot.io (Linux m4)

Received

Command cmd_test from @brendandahl received. Current queue size: 0

Live output at: http://54.241.84.105:8877/1dee551335dc3f6/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Nov 4, 2021

From: Bot.io (Windows)

Received

Command cmd_test from @brendandahl received. Current queue size: 0

Live output at: http://54.193.163.58:8877/a901a59dca7121b/output.txt

@brendandahl brendandahl mentioned this pull request Nov 4, 2021
Merged
@brendandahl
Copy link
Contributor Author

I should mention the two test issues added are slightly different problems, so I've added them both.

@brendandahl
Use correct matrix for patterns with showText.
1c70483 
We were incorrectly using the transform in the pattern before it had been
adjusted causing the pattern to be misplaced relative to the page.

Fixes: ShowText-ShadingPattern.pdf (already in corpus)
Fixes: mozilla#8111
Fixes: mozilla#9243
@pdfjsbot
Copy link

pdfjsbot commented Nov 5, 2021

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/1dee551335dc3f6/output.txt

Total script time: 23.41 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 2082
  different first/second rendering: 3

Image differences available at: http://54.241.84.105:8877/1dee551335dc3f6/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

pdfjsbot commented Nov 5, 2021

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/a901a59dca7121b/output.txt

Total script time: 42.14 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 2083
  different first/second rendering: 1

Image differences available at: http://54.193.163.58:8877/a901a59dca7121b/reftest-analyzer.html#web=eq.log

@brendandahl
Copy link
Contributor Author

Let's try that again after ref fixes...
/botio test

@pdfjsbot
Copy link

pdfjsbot commented Nov 5, 2021

From: Bot.io (Windows)

Received

Command cmd_test from @brendandahl received. Current queue size: 0

Live output at: http://54.193.163.58:8877/4f1e61be54d4640/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Nov 5, 2021

From: Bot.io (Linux m4)

Received

Command cmd_test from @brendandahl received. Current queue size: 0

Live output at: http://54.241.84.105:8877/768f1b2302ec69c/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Nov 5, 2021

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/768f1b2302ec69c/output.txt

Total script time: 21.23 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  errors: 676
  different ref/snapshot: 19
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/768f1b2302ec69c/reftest-analyzer.html#web=eq.log

@brendandahl
Copy link
Contributor Author

/botio-linux test

@pdfjsbot
Copy link

pdfjsbot commented Nov 5, 2021

From: Bot.io (Linux m4)

Received

Command cmd_test from @brendandahl received. Current queue size: 0

Live output at: http://54.241.84.105:8877/5e9d12eeea3f913/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Nov 5, 2021

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/4f1e61be54d4640/output.txt

Total script time: 42.04 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 35
  different first/second rendering: 1

Image differences available at: http://54.193.163.58:8877/4f1e61be54d4640/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

pdfjsbot commented Nov 5, 2021

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/5e9d12eeea3f913/output.txt

Total script time: 23.33 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 37

Image differences available at: http://54.241.84.105:8877/5e9d12eeea3f913/reftest-analyzer.html#web=eq.log

Snuffleupagus
Snuffleupagus approved these changes Nov 5, 2021
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, thanks for fixing these long-standing issues!

@Snuffleupagus Snuffleupagus merged commit 8222d65 into mozilla:master Nov 5, 2021
@Snuffleupagus
Copy link
Collaborator

/botio makeref

@pdfjsbot
Copy link

pdfjsbot commented Nov 5, 2021

From: Bot.io (Linux m4)

Received

Command cmd_makeref from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/f30f240439d7d01/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Nov 5, 2021

From: Bot.io (Windows)

Received

Command cmd_makeref from @Snuffleupagus received. Current queue size: 1

Live output at: http://54.193.163.58:8877/f6f5b4fb5a801f9/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Nov 5, 2021

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/f30f240439d7d01/output.txt

Total script time: 21.06 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

pdfjsbot commented Nov 5, 2021

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/f6f5b4fb5a801f9/output.txt

Total script time: 38.82 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees
No one assigned
Labels
core shading-pattern
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Displaced shading pattern incorrect shading of text
3 participants
@brendandahl @pdfjsbot @Snuffleupagus