Add an easy way to log to the terminal during browser tests. #14229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snuffleupagus
approved these changes
Nov 5, 2021
|
Unless I'm missing something here, I don't see any other code calling this. If it's intended to only be called manually, I would recommend we introduce a comment that says that to avoid this being deleted in the future during e.g., refactoring, since otherwise it's easy to think that it's dead code and can be removed. With that addressed, r=me too. |
|
Yeah, it's not being used currently. I've been using it when debugging. I'll add a comment. |
On the main thread call `driver.log` and the message will output in the terminal with the pdf id and the message. I've been using this a lot when trying to find certain PDFs or logging stats.
brendandahl
force-pushed
the
term-log
branch
from
5c3340d to
052db56
Compare
timvandermeij
approved these changes
Nov 19, 2021
|
Looks good now; thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the main thread call
driver.logand the message will output in theterminal with the pdf id and the message.
I've been using this a lot when trying to find certain PDFs or logging
stats.