-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Reset path bounding box tracking when starting a new path. #14228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Starting a new path will wipe out any of the current subpaths in the current graphics state, so we should reset the min/maxes. This makes a number of the bounding boxes smaller and reduces the number of composed pixels. For the smask tests in the corpus, the number of composed pixesl goes from 19,872,109 to 19,676,905. The difference is much larger on other PDFs though.
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @brendandahl received. Current queue size: 0 Live output at: http://54.241.84.105:8877/c709132c568c0dc/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @brendandahl received. Current queue size: 1 Live output at: http://54.193.163.58:8877/72f6ac319682aa9/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/c709132c568c0dc/output.txt Total script time: 23.72 mins
Image differences available at: http://54.241.84.105:8877/c709132c568c0dc/reftest-analyzer.html#web=eq.log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me, with passing tests; thank you!
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/72f6ac319682aa9/output.txt Total script time: 33.08 mins
Image differences available at: http://54.193.163.58:8877/72f6ac319682aa9/reftest-analyzer.html#web=eq.log |
/botio-windows browsertest |
From: Bot.io (Windows)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 1 Live output at: http://54.193.163.58:8877/2dda9084f86aca5/output.txt |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/2dda9084f86aca5/output.txt Total script time: 38.03 mins
Image differences available at: http://54.193.163.58:8877/2dda9084f86aca5/reftest-analyzer.html#web=eq.log |
Starting a new path will wipe out any of the current subpaths in the
current graphics state, so we should reset the min/maxes.
This makes a number of the bounding boxes smaller and reduces the number
of composed pixels. For the smask tests in the corpus, the number of
composed pixesl goes from 19,872,109 to 19,676,905. The difference is much
larger on other PDFs though.