Tweak the Bidi-detection heuristics for very short RTL strings (issue 11656) #14213
Conversation
Snuffleupagus
force-pushed
the
issue-11656
branch
from
806d72a to
6bf0f35
Compare
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 1 Live output at: http://54.241.84.105:8877/34c5b5f4cb7ab6c/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/34c5b5f4cb7ab6c/output.txt Total script time: 4.55 mins Published |
Snuffleupagus
force-pushed
the
issue-11656
branch
from
6bf0f35 to
0b22a55
Compare
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/d432eafc84682de/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 2 Live output at: http://54.193.163.58:8877/6f214fa6b2a48b9/output.txt |
… 11656) Very short strings can narrowly miss the existing Bidi-detection threshold, leading to incorrect text-selection and copying behaviour. In my testing, neither Adobe Reader or PDFium seem to handle copying "correctly" for this document. Hence it's not entirely clear to me that we actually want to fix this, since tweaking these heuristics can *obviously* cause regressions elsewhere (and our test coverage for RTL-text isn't exactly great).
Snuffleupagus
force-pushed
the
issue-11656
branch
from
0b22a55 to
5f77d37
Compare
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/d432eafc84682de/output.txt Total script time: 23.13 mins
Image differences available at: http://54.241.84.105:8877/d432eafc84682de/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/6f214fa6b2a48b9/output.txt Total script time: 42.29 mins
Image differences available at: http://54.193.163.58:8877/6f214fa6b2a48b9/reftest-analyzer.html#web=eq.log |
|
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/1d40311097a13dc/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 1 Live output at: http://54.193.163.58:8877/0dfe869f44e52d8/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/1d40311097a13dc/output.txt Total script time: 2.86 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/0dfe869f44e52d8/output.txt Total script time: 6.67 mins
|
|
/botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/f684c3cef106bcc/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 1 Live output at: http://54.193.163.58:8877/b0a7c0a5dc1bab4/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/f684c3cef106bcc/output.txt Total script time: 20.75 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/b0a7c0a5dc1bab4/output.txt Total script time: 38.88 mins
|
Very short strings can narrowly miss the existing Bidi-detection threshold, leading to incorrect text-selection and copying behaviour.
In my testing, neither Adobe Reader or PDFium seem to handle copying "correctly" for this document. Hence it's not entirely clear to me that we actually want to fix this, since tweaking these heuristics can obviously cause regressions elsewhere (and our test coverage for RTL-text isn't exactly great).