-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Add a RTL-text reference test (issue 10301) #14212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It seems that issue 10301 was fixed by PR 13424, by combining the spans, however given that we don't have a lot of test coverage for RTL-text I figured that adding a simple reference test wouldn't hurt (rather than just closing the issue as WORKSFORME).
Good idea to extend the test coverage a bit; thanks! /botio makeref |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 1 Live output at: http://54.193.163.58:8877/4122cc7c7888b3f/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/b72e0b4197ceb4a/output.txt |
/botio-windows makeref |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 1 Live output at: http://54.193.163.58:8877/0373c6542bfed8f/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/b72e0b4197ceb4a/output.txt Total script time: 19.08 mins
|
/botio-linux makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/4941da04f3e0fa1/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/4941da04f3e0fa1/output.txt Total script time: 20.68 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/4122cc7c7888b3f/output.txt Total script time: 39.54 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/0373c6542bfed8f/output.txt Total script time: 39.26 mins
|
It seems that issue #10301 was fixed by PR #13424, by combining the spans, however given that we don't have a lot of test coverage for RTL-text I figured that adding a simple reference test wouldn't hurt (rather than just closing the issue as WORKSFORME).