Skip to content

[Google Chrome] Ensure that markedContent spans are placed in the top-left corner (issue 14205) #14209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 9, 2021

Conversation

Snuffleupagus
Copy link
Collaborator

This is a tentative patch, since we unfortunately cannot easily test it (as far as I can tell).

In Firefox this (obviously) works as-is, but in Google Chrome the markedContent spans are inserted within the regular text-content (in the DOM) and with non-zero heights.

Fixes #14205

@Snuffleupagus
Copy link
Collaborator Author

/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/30aa2bb6e98216d/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/30aa2bb6e98216d/output.txt

Total script time: 4.26 mins

Published

@Orange57

This comment has been minimized.

@Snuffleupagus

This comment has been minimized.

…op-left corner (issue 14205)

*This is a tentative patch, since we unfortunately cannot easily test it (as far as I can tell).*

In Firefox this (obviously) works as-is, but in Google Chrome the `markedContent` spans are inserted within the regular text-content (in the DOM) and with non-zero heights.
@mozilla mozilla deleted a comment from pdfjsbot Nov 7, 2021
@mozilla mozilla deleted a comment from pdfjsbot Nov 7, 2021
@mozilla mozilla deleted a comment from pdfjsbot Nov 7, 2021
@mozilla mozilla deleted a comment from pdfjsbot Nov 7, 2021
@pdfjsbot
Copy link

pdfjsbot commented Nov 7, 2021

From: Bot.io (Linux m4)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/892e5c3b29b1b1f/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Nov 7, 2021

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/7071d8fd44e92d4/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Nov 7, 2021

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/892e5c3b29b1b1f/output.txt

Total script time: 23.27 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 8
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/892e5c3b29b1b1f/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

pdfjsbot commented Nov 7, 2021

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/7071d8fd44e92d4/output.txt

Total script time: 41.48 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 8
  different first/second rendering: 1

Image differences available at: http://54.193.163.58:8877/7071d8fd44e92d4/reftest-analyzer.html#web=eq.log

@brendandahl
Copy link
Contributor

Weird, I don't really understand why it's treated differently.

@brendandahl brendandahl merged commit 4ee906a into mozilla:master Nov 9, 2021
@Snuffleupagus Snuffleupagus deleted the issue-14205 branch November 9, 2021 16:19
@timvandermeij timvandermeij removed the request for review from brendandahl November 13, 2021 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Textlayer misplaced on Google Chrome
4 participants