[api-minor] Support rich content in markup annotation #14182

calixteman · 2021-10-24T15:36:16Z

use the xfa parser but in the xhtml namespace.

Snuffleupagus

In the existing annotation_layer.js code, we have a bunch of checks along these lines; should all of those perhaps have a parameters.data.richText-case added now?

Also, should an explicitly defined PopupAnnotation support rich-text; i.e. should we add richText: this.data.richText, at end of the parameters listed here?

pdf.js/src/display/annotation_layer.js

Lines 1578 to 1585 in 1ab9a6e

    
           const popup = new PopupElement({ 
        
             container: this.container, 
        
             trigger: Array.from(parentElements), 
        
             color: this.data.color, 
        
             titleObj: this.data.titleObj, 
        
             modificationDate: this.data.modificationDate, 
        
             contentsObj: this.data.contentsObj, 
        
           });

src/core/xfa/factory.js

Snuffleupagus · 2021-10-27T20:44:13Z

/botio-linux preview

pdfjsbot · 2021-10-27T20:44:14Z

From: Bot.io (Linux m4)

Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/884ff506b1bb41a/output.txt

pdfjsbot · 2021-10-27T20:48:31Z

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/884ff506b1bb41a/output.txt

Total script time: 4.26 mins

Published

Viewer: http://54.241.84.105:8877/884ff506b1bb41a/web/viewer.html
Viewer (legacy): http://54.241.84.105:8877/884ff506b1bb41a/legacy/web/viewer.html

test/pdfs/issue2966.pdf.link

calixteman · 2021-10-28T10:10:59Z

/botio test

pdfjsbot · 2021-10-28T10:11:00Z

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/cae80ad5a68eac4/output.txt

pdfjsbot · 2021-10-28T10:11:00Z

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/521b5b05e8a6aeb/output.txt

pdfjsbot · 2021-10-28T10:33:44Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/cae80ad5a68eac4/output.txt

Total script time: 22.72 mins

Font tests: Passed
Unit tests: Passed
Integration Tests: Passed
Regression tests: FAILED

  different ref/snapshot: 13
  different first/second rendering: 2

Image differences available at: http://54.241.84.105:8877/cae80ad5a68eac4/reftest-analyzer.html#web=eq.log

pdfjsbot · 2021-10-28T10:44:07Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/521b5b05e8a6aeb/output.txt

Total script time: 33.11 mins

Font tests: Passed
Unit tests: Passed
Integration Tests: Passed
Regression tests: FAILED

  errors: 671
  different ref/snapshot: 15

Image differences available at: http://54.193.163.58:8877/521b5b05e8a6aeb/reftest-analyzer.html#web=eq.log

src/core/annotation.js

src/display/annotation_layer.js

test/test_manifest.json

calixteman · 2021-10-29T12:57:34Z

/botio test

calixteman · 2021-10-30T13:06:48Z

/botio test

pdfjsbot · 2021-10-30T13:06:49Z

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/5266b98068c3358/output.txt

pdfjsbot · 2021-10-30T13:06:49Z

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/fa99a7089872852/output.txt

pdfjsbot · 2021-10-30T13:30:00Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/5266b98068c3358/output.txt

Total script time: 23.17 mins

Font tests: Passed
Unit tests: Passed
Integration Tests: Passed
Regression tests: FAILED

  different ref/snapshot: 37
  different first/second rendering: 2

Image differences available at: http://54.241.84.105:8877/5266b98068c3358/reftest-analyzer.html#web=eq.log

pdfjsbot · 2021-10-30T13:49:09Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/fa99a7089872852/output.txt

Total script time: 42.32 mins

Font tests: Passed
Unit tests: Passed
Integration Tests: FAILED
Regression tests: FAILED

  different ref/snapshot: 37
  different first/second rendering: 1

Image differences available at: http://54.193.163.58:8877/fa99a7089872852/reftest-analyzer.html#web=eq.log

Snuffleupagus

I was just about to land this, when it occurred to me that we can improve the API itself (for a non-viewer use-case); please see the inline comments.

src/core/annotation.js

src/core/xfa/html_utils.js

src/core/xfa/factory.js

src/display/annotation_layer.js

- use the xfa parser but in the xhtml namespace.

calixteman · 2021-10-31T12:45:36Z

/botio test

pdfjsbot · 2021-10-31T12:45:37Z

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/bb019a21c3b5146/output.txt

pdfjsbot · 2021-10-31T12:45:37Z

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/fe2f65d3ca1fc6c/output.txt

pdfjsbot · 2021-10-31T13:06:22Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/bb019a21c3b5146/output.txt

Total script time: 20.74 mins

Font tests: Passed
Unit tests: Passed
Integration Tests: Passed
Regression tests: FAILED

  errors: 673
  different ref/snapshot: 21
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/bb019a21c3b5146/reftest-analyzer.html#web=eq.log

Snuffleupagus · 2021-10-31T13:12:49Z

/botio-linux browsertest

pdfjsbot · 2021-10-31T13:12:51Z

From: Bot.io (Linux m4)

Received

Command cmd_browsertest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/7d9222fea67cf81/output.txt

pdfjsbot · 2021-10-31T13:28:03Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/fe2f65d3ca1fc6c/output.txt

Total script time: 42.42 mins

Font tests: Passed
Unit tests: Passed
Integration Tests: Passed
Regression tests: FAILED

  different ref/snapshot: 39
  different first/second rendering: 2

Image differences available at: http://54.193.163.58:8877/fe2f65d3ca1fc6c/reftest-analyzer.html#web=eq.log

pdfjsbot · 2021-10-31T13:32:53Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/7d9222fea67cf81/output.txt

Total script time: 20.03 mins

Regression tests: FAILED

  different ref/snapshot: 39
  different first/second rendering: 3

Image differences available at: http://54.241.84.105:8877/7d9222fea67cf81/reftest-analyzer.html#web=eq.log

Snuffleupagus

r=me, thanks for implementing this!

Snuffleupagus · 2021-10-31T13:42:24Z

/botio makeref

pdfjsbot · 2021-10-31T13:42:25Z

From: Bot.io (Linux m4)

Received

Command cmd_makeref from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/becd6a3beb90b3f/output.txt

pdfjsbot · 2021-10-31T13:42:25Z

From: Bot.io (Windows)

Received

Command cmd_makeref from @Snuffleupagus received. Current queue size: 1

Live output at: http://54.193.163.58:8877/f771cd5c81e8986/output.txt

Snuffleupagus · 2021-10-31T13:55:15Z

/botio-linux makeref

pdfjsbot · 2021-10-31T13:55:16Z

From: Bot.io (Linux m4)

Received

Command cmd_makeref from @Snuffleupagus received. Current queue size: 1

Live output at: http://54.241.84.105:8877/5d09940815e5a9b/output.txt

pdfjsbot · 2021-10-31T14:00:57Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/becd6a3beb90b3f/output.txt

Total script time: 18.52 mins

Lint: Passed
Make references: FAILED

pdfjsbot · 2021-10-31T14:21:43Z

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/5d09940815e5a9b/output.txt

Total script time: 20.76 mins

Lint: Passed
Make references: Passed
Check references: Passed

pdfjsbot · 2021-10-31T14:27:09Z

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/f771cd5c81e8986/output.txt

Total script time: 39.34 mins

Lint: Passed
Make references: Passed
Check references: Passed

calixteman requested review from Snuffleupagus and timvandermeij October 24, 2021 15:36

Snuffleupagus reviewed Oct 24, 2021

View reviewed changes

src/core/xfa/factory.js Outdated Show resolved Hide resolved

calixteman force-pushed the richtext branch from ea12e03 to 6b54253 Compare October 24, 2021 17:08

marco-c linked an issue Oct 25, 2021 that may be closed by this pull request

Support for Rich Text annotations #2966

Closed

calixteman removed a link to an issue Oct 25, 2021

Support for Rich Text annotations #2966

Closed

calixteman linked an issue Oct 25, 2021 that may be closed by this pull request

Support for Rich Text annotations #2966

Closed

timvandermeij added the annotations label Oct 27, 2021

Snuffleupagus reviewed Oct 28, 2021

View reviewed changes

test/pdfs/issue2966.pdf.link Outdated Show resolved Hide resolved

calixteman force-pushed the richtext branch from 6b54253 to 0499ca1 Compare October 28, 2021 09:00

mozilla deleted a comment from pdfjsbot Oct 28, 2021

calixteman force-pushed the richtext branch from 0499ca1 to ca3a55d Compare October 28, 2021 10:09

Snuffleupagus requested changes Oct 28, 2021

View reviewed changes

src/core/annotation.js Outdated Show resolved Hide resolved

src/display/annotation_layer.js Show resolved Hide resolved

test/test_manifest.json Show resolved Hide resolved

calixteman force-pushed the richtext branch from ca3a55d to 4ad9d22 Compare October 29, 2021 12:53

calixteman requested a review from Snuffleupagus October 30, 2021 14:04

Snuffleupagus reviewed Oct 30, 2021

View reviewed changes

src/display/annotation_layer.js Outdated Show resolved Hide resolved

Support rich content in markup annotation

cf8dc75

- use the xfa parser but in the xhtml namespace.

calixteman force-pushed the richtext branch from 9ecff54 to cf8dc75 Compare October 31, 2021 12:45

Snuffleupagus approved these changes Oct 31, 2021

View reviewed changes

Snuffleupagus merged commit 8c70258 into mozilla:master Oct 31, 2021

Snuffleupagus changed the title ~~Support rich content in markup annotation~~ [api-minor] Support rich content in markup annotation Oct 31, 2021

timvandermeij removed their request for review October 31, 2021 13:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[api-minor] Support rich content in markup annotation #14182

[api-minor] Support rich content in markup annotation #14182

calixteman commented Oct 24, 2021 •

edited

Loading

Snuffleupagus left a comment •

edited

Loading

Snuffleupagus commented Oct 27, 2021

pdfjsbot commented Oct 27, 2021

pdfjsbot commented Oct 27, 2021

calixteman commented Oct 28, 2021

pdfjsbot commented Oct 28, 2021

pdfjsbot commented Oct 28, 2021

pdfjsbot commented Oct 28, 2021

pdfjsbot commented Oct 28, 2021

calixteman commented Oct 29, 2021

calixteman commented Oct 30, 2021

pdfjsbot commented Oct 30, 2021

pdfjsbot commented Oct 30, 2021

pdfjsbot commented Oct 30, 2021

pdfjsbot commented Oct 30, 2021

Snuffleupagus left a comment

calixteman commented Oct 31, 2021

pdfjsbot commented Oct 31, 2021

pdfjsbot commented Oct 31, 2021

pdfjsbot commented Oct 31, 2021

Snuffleupagus commented Oct 31, 2021

pdfjsbot commented Oct 31, 2021

pdfjsbot commented Oct 31, 2021

pdfjsbot commented Oct 31, 2021

Snuffleupagus left a comment

Snuffleupagus commented Oct 31, 2021

pdfjsbot commented Oct 31, 2021

pdfjsbot commented Oct 31, 2021

Snuffleupagus commented Oct 31, 2021

pdfjsbot commented Oct 31, 2021

pdfjsbot commented Oct 31, 2021

pdfjsbot commented Oct 31, 2021

pdfjsbot commented Oct 31, 2021

	const popup = new PopupElement({
	container: this.container,
	trigger: Array.from(parentElements),
	color: this.data.color,
	titleObj: this.data.titleObj,
	modificationDate: this.data.modificationDate,
	contentsObj: this.data.contentsObj,
	});

[api-minor] Support rich content in markup annotation #14182

[api-minor] Support rich content in markup annotation #14182

Conversation

calixteman commented Oct 24, 2021 • edited Loading

Snuffleupagus left a comment • edited Loading

Choose a reason for hiding this comment

Snuffleupagus commented Oct 27, 2021

pdfjsbot commented Oct 27, 2021

From: Bot.io (Linux m4)

Received

pdfjsbot commented Oct 27, 2021

From: Bot.io (Linux m4)

Success

Published

calixteman commented Oct 28, 2021

pdfjsbot commented Oct 28, 2021

From: Bot.io (Linux m4)

Received

pdfjsbot commented Oct 28, 2021

From: Bot.io (Windows)

Received

pdfjsbot commented Oct 28, 2021

From: Bot.io (Linux m4)

Failed

pdfjsbot commented Oct 28, 2021

From: Bot.io (Windows)

Failed

calixteman commented Oct 29, 2021

calixteman commented Oct 30, 2021

pdfjsbot commented Oct 30, 2021

From: Bot.io (Linux m4)

Received

pdfjsbot commented Oct 30, 2021

From: Bot.io (Windows)

Received

pdfjsbot commented Oct 30, 2021

From: Bot.io (Linux m4)

Failed

pdfjsbot commented Oct 30, 2021

From: Bot.io (Windows)

Failed

Snuffleupagus left a comment

Choose a reason for hiding this comment

calixteman commented Oct 31, 2021

pdfjsbot commented Oct 31, 2021

From: Bot.io (Linux m4)

Received

pdfjsbot commented Oct 31, 2021

From: Bot.io (Windows)

Received

pdfjsbot commented Oct 31, 2021

From: Bot.io (Linux m4)

Failed

Snuffleupagus commented Oct 31, 2021

pdfjsbot commented Oct 31, 2021

From: Bot.io (Linux m4)

Received

pdfjsbot commented Oct 31, 2021

From: Bot.io (Windows)

Failed

pdfjsbot commented Oct 31, 2021

From: Bot.io (Linux m4)

Failed

Snuffleupagus left a comment

Choose a reason for hiding this comment

Snuffleupagus commented Oct 31, 2021

pdfjsbot commented Oct 31, 2021

From: Bot.io (Linux m4)

Received

pdfjsbot commented Oct 31, 2021

From: Bot.io (Windows)

Received

Snuffleupagus commented Oct 31, 2021

pdfjsbot commented Oct 31, 2021

From: Bot.io (Linux m4)

Received

pdfjsbot commented Oct 31, 2021

From: Bot.io (Linux m4)

Failed

pdfjsbot commented Oct 31, 2021

calixteman commented Oct 24, 2021 •

edited

Loading

Snuffleupagus left a comment •

edited

Loading