Handle ranges that "overflow" the last byte in CMap.mapBfRange (bug 1627427)

[Snuffleupagus]

Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1627427

[calixteman]

Maybe you could just add a test similar to:

pdf.js/test/unit/api_spec.js

Line 1659 in 0aaa4e3

it("gets text content, with no extra spaces (issue 13226)", async function () {

[Snuffleupagus]

Maybe you could just add a test similar to:

Sure, I've added a unit-test as well.
However I don't want to remove the text-test since in my experience it can be very tempting to just change the expected value in a unit-test, and thus accidentally accept a regression, compared to overlooking a ref-test failure.

[timvandermeij]

/botio test

[pdfjsbot]

From: Bot.io (Linux m4)

---

Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 1

Live output at: http://54.241.84.105:8877/56e086c9916fdeb/output.txt

[pdfjsbot]

From: Bot.io (Linux m4)

---

Success

Full output at http://54.241.84.105:8877/56e086c9916fdeb/output.txt

Total script time: 4.55 mins

Published

• Viewer: http://54.241.84.105:8877/56e086c9916fdeb/web/viewer.html
• Viewer (legacy): http://54.241.84.105:8877/56e086c9916fdeb/legacy/web/viewer.html

[Snuffleupagus]

/botio test

[pdfjsbot]

From: Bot.io (Linux m4)

---

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/ca8b915d2dc9e11/output.txt

[pdfjsbot]

From: Bot.io (Windows)

---

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 1

Live output at: http://54.193.163.58:8877/bf3473665023f8a/output.txt

[calixteman]

I get the exact same string in Acrobat.
I don't have the skills to evaluate the patch itself but at least it works.

[calixteman]

Maybe you could just add a test similar to:

Sure, I've added a unit-test as well. However I don't want to remove the text-test since in my experience it can be very tempting to just change the expected value in a unit-test, and thus accidentally accept a regression, compared to overlooking a ref-test failure.

I agree with you and at the same I'm not sure to be able to detect a visual regression with a glyph in a language I don't know at all.
So I speak for me only, but I think having 2 different ways to test that stuff is a good idea.

[pdfjsbot]

From: Bot.io (Linux m4)

---

Failed

Full output at http://54.241.84.105:8877/ca8b915d2dc9e11/output.txt

Total script time: 22.95 mins

• Font tests: Passed
• Unit tests: Passed
• Integration Tests: Passed
• Regression tests: FAILED

  different ref/snapshot: 7
  different first/second rendering: 3

Image differences available at: http://54.241.84.105:8877/ca8b915d2dc9e11/reftest-analyzer.html#web=eq.log

[pdfjsbot]

From: Bot.io (Windows)

---

Failed

Full output at http://54.193.163.58:8877/bf3473665023f8a/output.txt

Total script time: 41.20 mins

• Font tests: Passed
• Unit tests: Passed
• Integration Tests: FAILED
• Regression tests: FAILED

  different ref/snapshot: 13
  different first/second rendering: 3

Image differences available at: http://54.193.163.58:8877/bf3473665023f8a/reftest-analyzer.html#web=eq.log

[timvandermeij]

Thank you for fixing this!

[Snuffleupagus]

/botio makeref

[pdfjsbot]

From: Bot.io (Linux m4)

---

Received

Command cmd_makeref from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/34e362e5917a993/output.txt

[pdfjsbot]

From: Bot.io (Windows)

---

Received

Command cmd_makeref from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/9fa7e5c5bbc5bc3/output.txt

[pdfjsbot]

From: Bot.io (Linux m4)

---

Success

Full output at http://54.241.84.105:8877/34e362e5917a993/output.txt

Total script time: 20.69 mins

• Lint: Passed
• Make references: Passed
• Check references: Passed

[pdfjsbot]

From: Bot.io (Windows)

---

Success

Full output at http://54.193.163.58:8877/9fa7e5c5bbc5bc3/output.txt

Total script time: 38.87 mins

• Lint: Passed
• Make references: Passed
• Check references: Passed