Convert examples/image_decoders/jpeg_viewer.js to await/async #14123 #14167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@brendandahl and @marco-c Please help review. Thanks. |
Snuffleupagus
requested changes
Oct 20, 2021
stbensonimoh
force-pushed
the
convert-pdf-viewer-to-async-await
branch
from
8b9fa0d to
322ad53
Compare
stbensonimoh
force-pushed
the
convert-pdf-viewer-to-async-await
branch
from
322ad53 to
8f397e2
Compare
Comment on lines
28
to
29
| // Load the image data, and convert it to a Uint8Array. | ||
| // |
There was a problem hiding this comment.
As was also mentioned in #14167 (comment), please move this comment to just above the const response = await fetch(JPEG_IMAGE);-line instead.
stbensonimoh
force-pushed
the
convert-pdf-viewer-to-async-await
branch
from
8f397e2 to
f263c86
Compare
|
Thanks for your help and support too! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This converts examples/image_decoders/jpeg_viewers.js from using the old
XMLHttpRequesttoasync/await.This pull request
Convert examples/image_decoders/jpeg_viewers.js to await/async
Issue that this pull request solves
Closes: #14123
Checklist
Put an x in the boxes that apply