-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Ignore Square/Circle-annnotations with a zero borderWidth when creating a fallback appearance stream (issue 14164) #14166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ng a fallback appearance stream (issue 14164) Trying to render these Annotation-types, when the borderWidth is `0`, causes a "hairline" border to appear. If these Annotations included an appearance stream, as they are supposed to, this wouldn't have happened and the simplest solution here seem to be to just ignore these particular Annotations.
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/a0815dc479fed72/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/ea9ec549f710c4e/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/a0815dc479fed72/output.txt Total script time: 22.57 mins
Image differences available at: http://54.241.84.105:8877/a0815dc479fed72/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/ea9ec549f710c4e/output.txt Total script time: 41.51 mins
Image differences available at: http://54.193.163.58:8877/ea9ec549f710c4e/reftest-analyzer.html#web=eq.log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for doing that.
/botio makeref |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/6bc7e3a6a32920e/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/8d624f7bb172a4b/output.txt |
Thank you for solving the issue |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/8d624f7bb172a4b/output.txt Total script time: 20.50 mins
|
/botio-windows makeref |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 2 Live output at: http://54.193.163.58:8877/e91b0fef6821dde/output.txt |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/6bc7e3a6a32920e/output.txt Total script time: 30.73 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/e91b0fef6821dde/output.txt Total script time: 38.40 mins
|
Trying to render these Annotation-types, when the borderWidth is
0
, causes a "hairline" border to appear. If these Annotations included an appearance stream, as they are supposed to, this wouldn't have happened and the simplest solution here seem to be to just ignore these particular Annotations.Fixes #14164