Convert examples/node/pdf2svg.js to await/async #14125 #14159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snuffleupagus
requested changes
Oct 18, 2021
There was a problem hiding this comment.
Unfortunately this patch breaks the example, and running it no longer generates any svg-files at all. For future reference: Please don't submit a pull request unless you've successfully tested it locally.
To test this locally:
- Run
gulp dist-install. - cd into the
examples/node/directory. - Run
node pdf2svg.js. - Repeat step 3 after making changes to the example.
When addressing the comments, please keep https://github.com/mozilla/pdf.js/wiki/Squashing-Commits in mind.
stbensonimoh
force-pushed
the
convert-example-to-async-await
branch
from
1278cbf to
7b251aa
Compare
stbensonimoh
force-pushed
the
convert-example-to-async-await
branch
from
7b251aa to
10af5da
Compare
Snuffleupagus
approved these changes
Oct 20, 2021
stbensonimoh
force-pushed
the
convert-example-to-async-await
branch
from
10af5da to
0643ccb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
pdf2svg.jsuses chain of promisesThis pull request
Convert examples/components/simpleviewer.js to await/async
Issue that this pull request solves
Closes: #14125
Checklist
Put an x in the boxes that apply