Fix a xfaFaxtory typo in the shadowing in the PDFDocument.xfaFactory getter, and some other clean-up
#14152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ry` getter With this typo the shadowing doesn't actually work, which causes these checks to be unnecessarily repeated. In this particular case it didn't have a significant performance impact, however we should definately fix this nonetheless.
In these cases there's no good reason, in my opinion, to duplicate the `shadow`-lines since that unnecessarily increases the risk of simple typos (see the previous patch).
Also (slightly) simplifies a couple of small getters/methods related to the `XFAFactory`-instance.
…for consistency All other similar getters are called `numPages` throughout the code-base, and improved consistency should always be a good thing.
|
/botio xfatest |
From: Bot.io (Linux m4)ReceivedCommand cmd_xfatest from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/d9dbb4fdd40cb60/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_xfatest from @timvandermeij received. Current queue size: 1 Live output at: http://54.193.163.58:8877/144faa16643f60a/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/d9dbb4fdd40cb60/output.txt Total script time: 9.44 mins
Image differences available at: http://54.241.84.105:8877/d9dbb4fdd40cb60/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/144faa16643f60a/output.txt Total script time: 14.21 mins
Image differences available at: http://54.193.163.58:8877/144faa16643f60a/reftest-analyzer.html#web=eq.log |
timvandermeij
approved these changes
Oct 16, 2021
|
Nice find; thank you for fixing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please refer to the individual commit messages for additional details.