Convert examples/learning/helloworld64.html to await/async #14149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please make sure that the commit message reads "Convert examples/learning/helloworld64.html to await/async" since as-is it's not all that helpful. For future reference: Please avoid closing a PR and opening a new one. since that can easily lead prior discussions and review comments being overlooked. Note that it should always be possible, by using interactive rebasing, to fix merge conflicts and squash things (then followed by force-pushing to GitHub) such that the original PR can still be used. |
|
@Snuffleupagus I am sorry for the conflicts. I would definitely learn from your input ahead of my future PR's. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Convert examples/learning/helloworld64.html to await/async
Issue Pull Request solves
Closes #14122