-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Convert examples/text-only/pdf2svg.js to await/async #14141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're adding the function pageLoaded
but it isn't called anywhere so it's useless.
Isn't the problem actually that the patch adds a new function, rather than simply replacing the old one (as intended)? Furthermore, was this successfully tested locally? |
Oh! I've been confused because of the github UI.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned in #14141 (comment):
- Please confirm that you've successfully tested this locally.
- Please squash the commits, since we don't allow either fixup (or merge) commits to land; see https://github.com/mozilla/pdf.js/wiki/Squashing-Commits
311897c
to
b99cb82
Compare
Hi @Snuffleupagus @calixteman, I am really sorry for all the trouble. 🙏 This happens to be my first pull request and it being an open-source project got me all nervous and excited. 😅 I have now locally tested and fixed lint errors and squashed all commits into one. Thank you for your patience. 😊 I look forward to learning more! 💪 💃 |
The second sentence of the commit message, or at least the "and corrected lint errors"-part, doesn't seem appropriate here since it suggests that there were lint errors in the old code which isn't actually the case. |
Updated promise call back with await/async method
Oh, my bad! Fixed the commit message. 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For future reference: As outlined in https://github.com/mozilla/pdf.js/wiki/Contributing, you want to use feature branches rather than working directly against the "master" branch (since that makes working on more than thing at a time really difficult and causes e.g. rebasing to become more difficult).
r=me, thank you.
This is my first pull request.