docs: Fix grammatical error #14140
Closed
docs: Fix grammatical error #14140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs/contents/examples/index.md
Outdated
| @@ -81,7 +81,7 @@ var scaledViewport = page.getViewport({ scale: scale, }); | |||
| ### Hello World with document load error handling | |||
|
|
|||
| The example demonstrates how promises can be used to handle errors during loading. | |||
| It also demonstrates how to wait until page loaded and rendered. | |||
| It also demonstrates how to wait until page is loaded and rendered. | |||
There was a problem hiding this comment.
Isn't this sentence still grammatically incorrect though, since there should probably be an "a" before the word "page"; i.e. It also demonstrates how to wait until a page is loaded and rendered.
There was a problem hiding this comment.
Definitely, but as from my experience documentations don't adhere to usage of articles much. So it just depends on the community whether it strictly follows grammatical precision or not.
There was a problem hiding this comment.
Please also squash the commits, see https://github.com/mozilla/pdf.js/wiki/Squashing-Commits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a small grammatical error in docs.