Skip to content

Convert examples/node/pdf2png/pdf2png.js to await/async #14134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2021

Conversation

janekotovich
Copy link
Contributor

Because

Pdf2png.js uses chain of promises

This pull request

Convert examples/node/pdf2png/pdf2png.js to await/async

Issue that this pull request solves

Closes: #14126

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).

@janekotovich
Copy link
Contributor Author

janekotovich commented Oct 14, 2021

@Snuffleupagus Thanks heaps for help and sorry for misunderstanding.
I took into account all advices and hope this time pull req would be good 🤗
I tested patch with:

gulp dist-install 
gulp server
npm install
npm install canvas
cd examples/node/pdf2png
node pdf2png.js

and all seemed to work well. Let me know If you prefer me squashing commits in one 😊
Regards, Jane

@Snuffleupagus
Copy link
Collaborator

I tested patch with:
...
and all seemed to work well.

Thanks you!

Let me know If you prefer me squashing commits in one blush

Yes, please squash the commits (we generally use don't separate fixup commits in the PDF.js project).

@janekotovich janekotovich force-pushed the convert_pdf2png_to_async branch from 0d4ead6 to 37d90ec Compare October 14, 2021 10:37
@janekotovich
Copy link
Contributor Author

@Snuffleupagus Thanks Jonas all done! ✅

Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me; thank you for the patch!

@Snuffleupagus Snuffleupagus merged commit 9f9f076 into mozilla:master Oct 14, 2021
@janekotovich janekotovich deleted the convert_pdf2png_to_async branch October 27, 2021 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert examples/node/pdf2png/pdf2png.js to await/async
3 participants